search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.31k stars 449 forks source link

fix most warnings when building the reference manual #5808

Closed jhpalmieri closed 15 years ago

jhpalmieri commented 15 years ago

Along with #5541, this patch fixes most of the warnings when building the reference manual in 3.4.1.rc3. I still get these:

checking consistency... WARNING: /Applications/sage_builds/sage-3.4.1.rc3/devel/sage-test/doc/en/reference/sage/combinat/family.rst:: document isn't included in any toctree
done
preparing documents... WARNING: html_favicon is not an .ico file

but that's it.

Component: documentation

Issue created by migration from https://trac.sagemath.org/ticket/5808

JohnCremona commented 15 years ago
comment:1

John,

I just uploaded a patch at #4933 which fixes some of the same things for ell_rational_field and ell_generic. We might have difficulties merging these. I am about to test yours and hope to give a positive review shortly...

PS I would like to add \AA and \PP to the "blackboard bold" list (for affine and projective space). I read your clear instructions on how to do that, but have not done so as I thought you were probably touching that file.

JohnCremona commented 15 years ago

Apply after the first patch

JohnCremona commented 15 years ago
comment:2

Attachment: trac_5808-review.patch.gz

Applies fine to 3.4.1.rc3. When I did "sage -docbuild all html" I got lots of warnings in the tutrial (ok, not dealt with here) and a couple in algebras/quatalg/quaternion_algebra.py.

So I added some edits to that file, as in the second patch attached.

My positive review applies to the first patch. If John likes the second one, that's good.

jhpalmieri commented 15 years ago
comment:3

Hi John,

I think your patch to quaternion_algebra.py is going to clash with the one at #5541, mentioned in the summary above.

JohnCremona commented 15 years ago
comment:4

Replying to @jhpalmieri:

Hi John,

I think your patch to quaternion_algebra.py is going to clash with the one at #5541, mentioned in the summary above.

OK, kill that patch, I should not have wasted my time!

I'm about to add a patch doing what you suggested for mwrank. Which will make 4933 even harder to merge...so on second thoughts I will not post it here but will rebase my #4933 patch on this one and include the mwrank changes there.

UPSHOT: Positive review for ref-warnings.patch; ignore the seond one.

jhpalmieri commented 15 years ago
comment:5

Okay, thanks, and sorry for the extra work you'll have to do rebasing.

JohnCremona commented 15 years ago
comment:6

Replying to @jhpalmieri:

Okay, thanks, and sorry for the extra work you'll have to do rebasing.

No problem -- done!

jhpalmieri commented 15 years ago

Attachment: ref-warnings.patch.gz

apply only this patch

jhpalmieri commented 15 years ago
comment:7

This version removes the "..link::" directives from sudoku.py; otherwise, it's identical to the previous patch.

jhpalmieri commented 15 years ago
comment:8

mabshoff: the only issue with the latest patch is whether it passes doctests. I think it does; if you agree, I think you can re-issue the positive review.

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago
comment:9

With only ref-warnings.patch applied doctests do pass. So I am reinstating the positive review.

Cheers,

Michael

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago
comment:10

Merged in Sage 3.4.1.rc4.

Cheers,

Michael