search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.39k stars 472 forks source link

untabify Sage #5848

Closed jhpalmieri closed 15 years ago

jhpalmieri commented 15 years ago

The attached patch removes all of the TABs I could find in .py and .pyx files in the Sage library.

CC: @roed314

Component: misc

Issue created by migration from https://trac.sagemath.org/ticket/5848

1d7ec08f-60ae-4512-91a6-8324c06eab9f commented 15 years ago
comment:1

Attachment: untabify.patch.gz

Patch choked twice on modular/dirichlet.py, which seems odd, given how fresh it is, and I can't really tell why. I was applying it to an upgraded 3.4.1.rc4 Maybe it will patch better under mabshoff's firm guidance.

Builds just fine. Passes sage -testall, except some unpickling errors in structure/sage_object.pyx and algebras/quaternion_algebra_element.py concerning QuaternionAlgebraElements, but the changes to these files don't appear implicated in these errors,

Documentation builds fine as well (PDF of reference manual) with no TeX errors.

Positive review, subject to the business above about patching modular/dirichlet.py.

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago
comment:2

I am not sure which rejects Rob saw, but it is applying fine for me.

Cheers,

Michael

1d7ec08f-60ae-4512-91a6-8324c06eab9f commented 15 years ago
comment:3

Replying to @sagetrac-mabshoff:

I am not sure which rejects Rob saw, but it is applying fine for me.

Superior Merge-Fu. ;-)

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago
comment:4

Ok, the patch still applies modulo three the diff for three files

that no longer exist. This patch besides the latex one I just merged at #5610 has high risks for rejects, but since I merged the other one I might as well merge this one.

David: Some of the padics files are touched, so if you rebase your patch bomb in the morning please also apply the patch I will post in a minute.

Cheers,

Michael

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago

John's patch with the changes for three no longer existing files removed.

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago
comment:5

Attachment: trac_5848_untabify.patch.gz

Merged trac_5848_untabify.patch in Sage 3.4.2.alpha0.

Cheers,

Michael