simplicial complexes: change 'facets' from an attribute to a method

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.3k stars 449 forks source link

simplicial complexes: change 'facets' from an attribute to a method #6141

Closed jhpalmieri closed 15 years ago

jhpalmieri commented 15 years ago

See this thread from sage-devel.

Component: algebraic topology

Author: John Palmieri

Reviewer: David Perkinson

Merged: 4.0.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6141

jhpalmieri commented 15 years ago

Attachment: facets.patch.gz

bc92013b-9220-40da-a45f-06c52942e68d commented 15 years ago

comment:1

The patch makes a simple change. The attribute self.facet is changed to self._facet in all files in the homology directory, and a facets() method is added. I checked the new code, ran the doctests in homology, and tried a few examples of my own. Everything was OK.

I was using Sage Version 4.0.alpha0, Release Date: 2009-05-15 under Fedora 10.

mwhansen commented 15 years ago

comment:2

While this does represent a backwards incompatible change, I think it is better to resolve it now while the code is newer.

Merged in 4.0.1.alpha0.

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 15 years ago

Reviewer: David Perkinson

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 15 years ago

Merged: 4.0.1.alpha0

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 15 years ago

Author: John Palmieri