Python Imaging Library interface

wdjoyner commented 15 years ago

The attached patch implements several functions providing a simpler interface to the Python Imaging Library. For example, you can sharpen the image of an image on the internet you have the url of and save it to Sage's tmp subdirectory.

Apply:

Component: packages: standard

Work Issues: doc, font_manager

Branch/Commit: u/chapoton/6741 @ 3fd7a6e

Issue created by migration from https://trac.sagemath.org/ticket/6741

wdjoyner commented 15 years ago

Attachment: trac_6741-pil.patch.gz

requires pil-1.1.6, applies to 4.1.1.rc2

wdjoyner commented 15 years ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 The attached patch implements several functions providing a simpler interface to the Python Imaging Library. For example, you can sharpen the image of an image on the internet you have the url of and save it to Sage's tmp subdirectory.
+
+

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 15 years ago

comment:4

This sage-devel thread has a discussion about making PIL a standard spkg. The vote for doing so was carried out in that thread.

jasongrout commented 15 years ago

comment:5

This looks very nice. However, the doctests write to SAGE_ROOT/tmp, which means that a normal user cannot run doctests on this file. Isn't there somewhere else that we should write temporary data during a doctest? Maybe using SAGE_TMP or something like that?

jasongrout commented 15 years ago

comment:6

I guess there isn't a SAGE_TMP. How about a temporary directory under .sage?

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 15 years ago

comment:7

Replying to @jasongrout:

I guess there isn't a SAGE_TMP. How about a temporary directory under .sage?

Yes.

jasongrout commented 15 years ago

comment:8

Nice work; thanks for doing this!

Marking as "needs work" for the following reasons:

Doctests which rely on internet should be marked "optional - requires internet"
image_convert should probably let me specify an output file name, or by default write in the current directory so that we can use it easily in the notebook (e.g., we convert something and it magically appears in the cell output).
someone should test this on a mac and then remove the note about it not being tested on a mac
stylistically, it looks like there is lots of duplicated code that opens files from the internet; maybe this could be refactored into a single function (and then used for image_convert as well)?

wdjoyner commented 14 years ago

comment:9

Replying to @jasongrout:

Nice work; thanks for doing this!

Marking as "needs work" for the following reasons:

Arrgghh ... Just saw this now, going through old emails.

I will try to work on these referee comments/suggestions now. It probably needs rebasing anyway. Sorry for the late reply.

wdjoyner commented 14 years ago

comment:10

Good news: it applies fine and does not need rebasing.

Bad news: Now I can't even get the code to work. I've tried on an imac (which requires some extra work to get libjpeg to install) and on an ubuntu machine. Probably I'm missing something obvious, but I don't know what it is.