Closed williamstein closed 15 years ago
Attachment: trac_6751.patch.gz
Apply after previous
Attachment: trac_6751-review.patch.gz
Looks good to me: applies fine to 4.1.1, tests pass, some examples I tried looked correct (as does the code).
There's one small typo ("had" for "has" in the docstring) which I put into a second patch (overkill perhaps!)
Reviewer: John Cremona
Author: William Stein
Merged both patches. The patch trac_6751.patch
applies OK, but with fuzz:
[mvngu@sage sage-main]$ hg qimport https://github.com/sagemath/sage-prod/files/10645881/trac_6751.patch.gz && hg qpush
adding trac_6751.patch to series file
applying trac_6751.patch
patching file sage/algebras/quatalg/quaternion_algebra_element.pyx
Hunk #1 succeeded at 537 with fuzz 2 (offset -76 lines).
Now at: trac_6751.patch
Merged: Sage 4.1.2.alpha0
See #6846 for a follow up to this ticket.
This patch could possibly depend on #6745.
The goal of this patch is to implement computation of the ternary quadratic form associated to an order in a rational quaternion algebra. These are useful, e.g, in computing with Heegner points, in decided whether quaternion orders have embeddings from orders in quadratic imaginary fields, and in computing elements of the Kohnen + subspace of modular forms of weight 3/2.
Component: algebra
Author: William Stein
Reviewer: John Cremona
Merged: Sage 4.1.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/6751