Ideals of a Hecke Algebra

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.45k stars 481 forks source link

Ideals of a Hecke Algebra #6830

Open b645e621-c8d9-404b-89d5-ffb9b144f158 opened 15 years ago

b645e621-c8d9-404b-89d5-ffb9b144f158 commented 15 years ago

Added code for ideals of a Hecke algebra. This patch depends on the basis of a Hecke algebra code from ticket #6768 (so ignore stuff about Hecke bases).

CC: @rharron

Component: modular forms

Keywords: ideal, hecke

Author: Preston Wake

Branch/Commit: u/kedlaya/Ideals_of_a_Hecke_Algebra @ 879fe45

Issue created by migration from https://trac.sagemath.org/ticket/6830

b645e621-c8d9-404b-89d5-ffb9b144f158 commented 15 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Added code for ideals of a Hecke algebra.
+Added code for ideals of a Hecke algebra. This patch depends on the basis of a Hecke algebra code from ticket #6768.

b645e621-c8d9-404b-89d5-ffb9b144f158 commented 15 years ago

comment:1

This patch depends on the basis of a Hecke algebra code from ticket #6768

b645e621-c8d9-404b-89d5-ffb9b144f158 commented 15 years ago

comment:2

Attachment: ideal.patch.gz

b645e621-c8d9-404b-89d5-ffb9b144f158 commented 15 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Added code for ideals of a Hecke algebra. This patch depends on the basis of a Hecke algebra code from ticket #6768.
+Added code for ideals of a Hecke algebra. This patch depends on the basis of a Hecke algebra code from ticket #6768 (so ignore stuff about Hecke bases).

JohnCremona commented 15 years ago

comment:3

The patch is now visible; I don't have time to test it very soon , sorry.

JohnCremona commented 14 years ago

comment:4

Could you rebase this to apply to 4.3.alpha1? As it stands the patch does not apply, but I expect it will be an easy fix.

Generally the code looks good to me (though there is at least one functions with no doctests at present).

Once rebased, I'll test it properly.

kedlaya commented 8 years ago

comment:5

Just discovered this moribund ticket. I might actually find this useful! Does anyone intend to revisit this?

kedlaya commented 8 years ago

comment:7

To quote an email from wakep: "I wrote that code as part of an undergraduate summer research program. I was not particularly savvy with Sage development then (and even less-so now). As far as I understand, the reason that it became moribund is that it took some time to get an initial review, and by the time it got one, Sage was on to a new version. I was asked to "rebase" it to the new version, but I didn't know how to do that. (I had started graduate school by then and had no time to play with Sage.)

The upshot is that I have no particular intention to revisit the code, but I think that it wouldn't take much to get it working. I'd be happy to work on it, but I wouldn't know what to do."

So I (kedlaya) took the liberty of manually rebasing the patch. I haven't even tried to build this yet; probably that will reveal some other issues.

New commits:

1258047 Rebase to 7.4beta0

kedlaya commented 8 years ago

Branch: u/kedlaya/Ideals_of_a_Hecke_Algebra

kedlaya commented 8 years ago

Commit: 1258047

kedlaya commented 8 years ago

comment:8

robharron points out that it would be more robust to create the Hecke algebra as an abstract ring (represented internally as a quotient of a polynomial ring over Z) plus maps back and forth (e.g., given N, turn the N-th Hecke operator into an abstract ring element). Then one could deal with ideals on the ring side, which would give access to all existing commutative algebra functionality.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 1258047 to 879fe45

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

879fe45 More minor edits to make this compile