move some commutative algebra to libSingular functions interface

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.37k stars 462 forks source link

move some commutative algebra to libSingular functions interface #6909

Closed malb closed 14 years ago

malb commented 15 years ago

Implement a couple of functions using the new libsingular functions interface (#6628).

Component: commutative algebra

Author: Martin Albrecht

Reviewer: Michael Brickenstein, Burcin Erocal

Merged: sage-4.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6909

malb commented 15 years ago

comment:1

Attachment: libsingular_more_functions.patch.gz

The attached patch

implements a Pythonic interface to the Singular options
fixes a bug where local orderings were not used correctly
switches groebner_basis() and elimination_ideal() to libsingular.

For most functions on multivariate polynomial ideals we first need to wrap libSingular lists since many functions return lists. This would require an updated SPKG.

1998e663-c3b5-4cf6-92c3-7f1771ca5185 commented 15 years ago

comment:2

Hi, I spent 10 minutes reading the code and like it (this is not a formal review). Cheers, Michael

burcin commented 14 years ago

rebased to 4.1.2.rc0

burcin commented 14 years ago

Reviewer: Michael Brickenstein, Burcin Erocal

burcin commented 14 years ago

comment:3

Attachment: trac_6909-libsingular_more_functions.patch.gz

Positive review.

Apply only attachment: trac_6909-libsingular_more_functions.patch, which is a rebase of Martin's patch to 4.1.2.rc0.

mwhansen commented 14 years ago

Merged: sage-4.2.alpha0