modular forms -- add aplist and anlist for newforms

williamstein commented 15 years ago

Component: modular forms

Keywords: newform

Work Issues: doctest failures

Branch/Commit: u/chapoton/6959 @ 1c4b7f9

Issue created by migration from https://trac.sagemath.org/ticket/6959

williamstein commented 15 years ago

Attachment: trac_6959.patch.gz

JohnCremona commented 14 years ago

comment:2

Looks mainly good to me -- patch applies and tests (in sage/modular/modform) pass. One glitch:

        if not all_embeddings: 
                return A 
    return A

looks like a typo.

It does not seem very efficient to factor all the n in the range, and that is not the way I have always done this. The result is pretty slow -- for example, if you wanted to compute all a_n for n<10^6, this is not good enough:

sage: f = CuspForms(11,2).newforms()[0]; f
q - 2*q^2 - q^3 + 2*q^4 + q^5 + O(q^6)
sage: time an = f.anlist(1000)
CPU times: user 0.40 s, sys: 0.00 s, total: 0.40 s
Wall time: 0.40 s
sage: time an = f.anlist(10000)
CPU times: user 13.84 s, sys: 0.79 s, total: 14.63 s
Wall time: 14.65 s
sage: time an = f.anlist(100000)
#(gave up waiting after a few minutes)

On second thoughts it is probably computing the a_p which is slow here. But are they even cached?

sage: time an = f.aplist(10000)
CPU times: user 11.09 s, sys: 0.65 s, total: 11.74 s
Wall time: 11.81 s
sage: time an = f.anlist(10000)
CPU times: user 13.71 s, sys: 0.69 s, total: 14.40 s
Wall time: 14.53 s

-- it seems not.

fchapoton commented 11 years ago

Changed keywords from none to newform

fchapoton commented 11 years ago

Work Issues: doctest failures

fchapoton commented 11 years ago

comment:4

there are three failing doctest (sage 5.12.beta4)

fchapoton commented 10 years ago

Branch: u/chapoton/6959

fchapoton commented 10 years ago

Commit: 1e47fb5

fchapoton commented 10 years ago

New commits:

`0a0ab2b`	`trac 6959 -- modular forms -- add aplist and anlist for newforms`
`1e47fb5`	`trac #6959 a little bit of pep8 cleanup`

fchapoton commented 10 years ago

comment:8

The 3 failing doctests looks to me like a problem with galois ambiguity (i.e. an algebraic number a1 is replaced by its conjugate -a1). Maybe one can just replace them by the results ?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a5574ae Merge branch 'u/chapoton/6959' into 7.1.b5

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 8 years ago

Changed commit from 1e47fb5 to a5574ae

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Changed commit from a5574ae to 2374ede

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 7 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

2374ede Merge branch 'u/chapoton/6959' in 8.0.b9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Changed commit from 2374ede to 1c4b7f9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 6 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

1c4b7f9 Merge branch 'u/chapoton/6959' in 8.2.b8

sagemath / sage

modular forms -- add aplist and anlist for newforms #6959