Closed dandrake closed 14 years ago
On second thought, scratch the -1 idea. We can just make one change to sage-ptest: line 267 could be
numthreads = min(8, multiprocessing.cpu_count())
Anyone who is desperate to saturate a machine with more than 8 cores can just specify it on the command line.
add in default maximum of 8 threads
Attachment: trac_7011.patch.gz
patch for $SAGE_ROOT/makefile
Author: Dan Drake
Attachment: trac_7011-sage-root-makefile.patch.gz
I've uploaded patches for the sage_scripts repo, and for the root makefile. The second attachment is an ordinary unified diff.
Looks good to me. Very helpful comments, too.
Reviewer: John Palmieri
merged into sage-4.1.2
At #6283, we changed the parallel testing framework so that it automatically uses all the cores/threads available, but perhaps this is not the best solution.
Dave says ([#6283 comment:9]) "I would have personally not allowed the default to exceed 8", so maybe we can incorporate his limit in a way that still lets ordinary multicore computers be well-used:
On sage-devel, I suggested that a solution that works really well for 99+% of people is a good one -- and since most "regular" machines on which Sage is doctested have 8 or fewer cores, this still works fine for them, and with the above suggestion, people won't bring sage.math or t2.math to their knees.
Thoughts?
CC: @sagetrac-mvngu @sagetrac-drkirkby @jhpalmieri
Component: doctest coverage
Author: Dan Drake
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/7011