Closed 41051cdb-393d-4861-8e3e-611cc2de81d7 closed 9 years ago
Changed author from colah to colah, Frédéric Chapoton
Branch: u/chapoton/7744
Useful for 3D printers, see http://www.thingiverse.com/thing:12784 for an interesting use case.
I have mostly rewritten the code for better efficiency.
Maybe this could be added in some way to the options of .save
?
And it would be much better to use the binary STL format instead.
New commits:
37a9d05 | trac #7744 code for producing STL files for surfaces in sagemath |
Changed author from colah, Frédéric Chapoton to Christopher Olah, Frédéric Chapoton
Branch pushed to git repo; I updated commit sha1. New commits:
20ba42b | trac #7744 add AMF export |
I have tested the STL export by loading the result in FreeCAD, and it works. I have now added the "more modern" xml-based AMF format, but not tested that it works sor far, as FreeCAD is not able to load that file format.
It is necessary to compress the AMF file with ZIP..
Branch pushed to git repo; I updated commit sha1. New commits:
63b6ec9 | trac #7744 more formats one can save (and x3d is the best) |
Branch pushed to git repo; I updated commit sha1. New commits:
2a11337 | trac #7744 added the PLY file format |
Maybe one could add the json format ?
Branch pushed to git repo; I updated commit sha1. New commits:
56a75e7 | trac #7744 minor details, more doc |
Let us forget about the json format, which is private between sage and sagenb.
I think this ticket is ready for review now. It would be very useful to have it merged for use in #12212.
Branch pushed to git repo; I updated commit sha1. New commits:
a2c486e | Merge with 6.4.beta0 |
patchbot has turned green ! time for a review, anybody ?
I will take a look at it next week, when i will have my 3d printer available to check the output.
Changed keywords from 3D-Printing STL to 3D-Printing, STL, X3D
Hello ! have you checked that the output is accepted by your 3d printer ?
Yes, it did work fine.
Branch pushed to git repo; I updated commit sha1. New commits:
d43d75c | trac #7744 minor details |
Branch pushed to git repo; I updated commit sha1. New commits:
1c7510b | Merge branch 'u/chapoton/7744' of trac.sagemath.org:sage into 6.4.b6 |
Hello ? This one would be useful for #12212.
I guess - this is pretty far outside my domain, anyway. The changes here are not compatible with the ones at #16640, for what it's worth, though probably are easily taken into account.
ping ? anybody for a review ?
Branch pushed to git repo; I updated commit sha1. New commits:
94a4385 | Merge branch 'u/chapoton/7744' into 6.6.b3 |
Could please someone have a look at that ? it has already started rotting..
There are some people interested by this kind of stuff, see here : http://ask.sagemath.org/question/26075/transferring-3d-plots/
Still nobody for a review ?
Branch pushed to git repo; I updated commit sha1. New commits:
6b716f6 | Merge branch 'u/chapoton/7744' of trac.sagemath.org:sage into 7744 |
ping ?
please, is there anybody to have a look ? this is not that complicated, just a few text-writing routines.
I am looking at it.
Some comments:
Would there be some way to doctest the saving feature? Maybe saving to a temporary file, then reading it, showing some part of the content and erasing.
The warning about only working for triangulated surfaces should go in a Warning section
Otherwise the code looks good, although i am having some trouble to rebase it to latest version in order to test it.
Thanks. I am available, so one can hope to make progress together.
I will wait for your review, unless you want me to make the required changes myself right now.
If you make the changes i suggested, and also rebase it to the latest development branch, i can test it and give the positive review.
ok, I am doing that right now.
Reviewer: Miguel Marco
CC: @nilesjohnson @kcrisman @jdemeyer @sagetrac-tmonteil
Component: graphics
Keywords: 3D-Printing, STL, X3D
Author: Christopher Olah, Frédéric Chapoton
Branch/Commit:
09cba3c
Reviewer: Miguel Marco
Issue created by migration from https://trac.sagemath.org/ticket/7744