search

sagemath / sage

Main repository of SageMath. Now open for Issues and Pull Requests.
https://www.sagemath.org
Other
1.2k stars 413 forks source link

SageNB 0.7.x #8051

Closed e14f4152-4982-4ace-8c95-73a0599b109b closed 14 years ago

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

The new spkg is at

Merged in 0.7: #7249, #7962, #7969, #4217, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

Merged in 0.7.1: #8103.

Merged in 0.7.2: #3083's "notruncate" patch.

Merged in 0.7.3: #7784.

Merged in 0.7.4: #8167, #8102, #8160.

Component: notebook

Author: Mitesh Patel

Reviewer: Robert Mařík, Minh Van Nguyen, Alex Leone

Merged: sage-4.3.2

Issue created by migration from https://trac.sagemath.org/ticket/8051

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Author: Mitesh Patel

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -1 +1,6 @@
-New spkg.
+The new spkg is at
+
+* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.spkg
+
+Merged tickets: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434
+
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:2

If it's possible, I'd like to get into 0.7.1 as many of the now remaining "needs review" tickets as we can. I'm rebasing these now.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:3

Replying to @qed777:

If it's possible, I'd like to get into 0.7.1 as many of the now remaining "needs review" tickets as we can. I'm rebasing these now.

Here's a possible queue:

trac_7784-hgignore_update.patch
trac_5712-interrupt-notification.5.patch
trac_6069-missing_pub_ws.2.patch
trac_8038-email_plus_addressing_v2.patch
trac_7506-notebook_object-documentation.2.patch
trac_693-spawn_notebook.3.patch
trac_5177-delete-cell-dirs.3.patch
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Blockedby: 7249

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Changed blockedby from 7249 to none

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,6 +1,8 @@
 The new spkg is at

-* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.spkg
+* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.1.spkg

-Merged tickets: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434
+Merged in 0.7: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

+Merged in 0.7.1: #8103.
+
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -6,3 +6,4 @@

 Merged in 0.7.1: #8103.

+**Note:** Please first review #3083's "notruncate" patch.
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:7

I just noticed that long 'eval' docstrings are truncated. I'll add a reviewer patch to #3083.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,9 +1,9 @@
 The new spkg is at

-* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.1.spkg
+* [http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.2.spkg](http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.1.spkg)

 Merged in 0.7: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

 Merged in 0.7.1: #8103.

-**Note:** Please first review #3083's "notruncate" patch.
+Merged in 0.7.2:  #3083's "notruncate" patch.
34f90a52-c114-47db-a93b-3f83978622c0 commented 14 years ago
comment:9

All tickets got positive review and have been merged. So what should be reviewed in this ticket?

I installed the spkg, seems to work fine (but I did not test everything), is this enough to give positive review?

btw: the link from description "says" http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.2.spkg but it points to http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.1.spkg

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 14 years ago
comment:10

Replying to @robert-marik:

All tickets got positive review and have been merged. So what should be reviewed in this ticket?

You need to make sure that you can successfully install the updated spkg.

I installed the spkg, seems to work fine (but I did not test everything), is this enough to give positive review?

I would say, all doctests must pass as well. In any case, if you can't run all doctests after installing the updated spkg, I can do that. A correct link to the updated spkg is

http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.2.spkg

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 14 years ago
comment:11

I don't understand why the spkg is not managed by Mercurial:

[mvngu@mod sagenb-0.7.2]$ hg st
abort: There is no Mercurial repository here (.hg not found)!

The file spkg-install should have its executable bits on:

[mvngu@mod sagenb-0.7.2]$ ls -g spkg-install
-rw-r--r-- 1 mvngu 348 2010-01-30 16:37 spkg-install

And SPKG.txt is very sketchy about update details.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:12

I suggest

Ideally, you should run the SageNB Selenium tests, too. But they require special extra setup. I'll make simplifying that setup a separate ticket.

Thanks for pointing out the link error. I've updated it.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:13

The repository is in sagenb-0.7.2/src/sagenb. We auto-generate the package with sagenb-0.7.2/src/sagenb/spkg-dist.

I suggest that I make a separate ticket to update SPKG.txt.

See #7784 about

$ hg stat
? release_notes.txt
? setup.cfg
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:14

Replying to @qed777:

I suggest that I make a separate ticket to update SPKG.txt.

Or I can do this here later today.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:15

I'll fix the spkg-install problem, too.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Reviewer: Robert Mařík, Minh Van Nguyen

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:16

Please see #7784 for the changes. If/when that ticket gets a positive review, I'll create SageNB 0.7.3 and post it here.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:17

By the way, it seems that for the near future, I may be the only very active SageNB developer. I'd be very happy to be proved (proven?) wrong! There are many tasks to complete --- there are several cool new notebook features to implement. It's not possible for me to cover them all, and I'd like to avoid stalling ongoing development.

To this end, I'll try to make it easier for Sage developers to review notebook tickets or make other contributions. Please let me know what would help. For example, I can make experimental spkgs that contain the latest patches in the queue. Those who wish just to test the cumulative changes can install the package with sage -f sagenb-*.spkg. But reviewers can also open the spkg, pop / push patches, and comment on specific ticket(s). In either case, we'll get useful information about how the notebook behaves in a wider gamut of browser-OS combinations. We'll also get more end user feedback.

6f4d16f1-6707-43c2-b378-bb8475bbf970 commented 14 years ago
comment:18

Experimental spkgs would be good. I think the best way to get more testing/review would be a good guide to applying patches, testing spkgs, etc.

Is there a mailing list or wiki page for coordinating development effort?

7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 14 years ago
comment:19

Replying to @sagetrac-acleone:

Is there a mailing list or wiki page for coordinating development effort?

A relevant mailing is sage-devel. Most of the time, that list receives high volume traffic on development discussion. For coordinating release effort, the sage-release mailing list is appropriate. Some effort is underway to expand the Sage documentation with information to help beginners getting started with Sage development. The relevant tickets are:

  1. 8108: Expand the Sage Developer Guide for newcomers

  2. 6987: reorganize section on producing patches with Mercurial

  3. 8079: Better documentation for patching spgk's

  4. 8104: developer's guide for making spkgs should specify that patches need to be version controlled

  5. 3882: explain in the programming guide why spkg source patches should be applied by copying entire files

  6. 7944: update Developers' Guide to reflect new process for working on tickets

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:20

Both sage-devel and sage-notebook are good places. I suppose we should move this discussion to sage-notebook.

One source for ideas is SageTasks, but it may be getting old.

Addendum: Of course, we should also try to attract energetic developers who'd contribute fresh ideas, techniques, etc., to the SageNB project.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:21

While I'm here, I'd also like to suggest using alpha.sagenb.org or creating ouch.sagenb.org to test a bleeding-edge SageNB. This could be a notebook with all positively reviewed patches applied or, more interestingly, an experimental spkg.

We could also set up a corresponding repository, different from http://boxen.math.washington.edu:8100/, to which to push experimental features and from which to backport what works. A potential problem here is that Mercurial changesets are immutable. But we might not care about keeping the history of this repository clean.

Just some thoughts.

34f90a52-c114-47db-a93b-3f83978622c0 commented 14 years ago
comment:22

Installs fine, works fine with jsmath image fonts, tests paseed, cannot check the rest, since I have probably old hg in my Debian Linux

sage@um-bc107:~/sagenb-0.7.2/src/sagenb$ hg log
abort: requirement 'fncache' not supported!
sage@um-bc107:~/sagenb-0.7.2/src/sagenb$ hg status
abort: requirement 'fncache' not supported!

Can someone finish testing? I think that this is very important ticket and nice sage notebook is important to attract new users (and new developers). Thank you for working on it.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:23

If you have a spare moment, please review #7784, which is "blocking" this ticket.

You can use sage -hg instead of hg.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:24

Minh -- Even with #8036, it's very likely the PDF reference manual won't build with this spkg, owing to #7249's Unicode doctests. I'm not sure what we should do about this.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,9 +1,11 @@
 The new spkg is at

-* [http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.2.spkg](http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.1.spkg)
+* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.3.spkg

 Merged in 0.7: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

 Merged in 0.7.1: #8103.

 Merged in 0.7.2:  #3083's "notruncate" patch.
+
+Merged in 0.7.3: #7784.
7c09a680-e216-4024-bb8e-9bfd4aa7f313 commented 14 years ago
comment:25

Replying to @qed777:

Minh -- Even with #8036, it's very likely the PDF reference manual won't build with this spkg, owing to #7249's Unicode doctests. I'm not sure what we should do about this.

The release deadline for Sage 4.3.2 is Saturday 06th February 2010, which means there's not much time for sorting out failures when building the PDF version of the reference manual. I think sagenb-0.7.3.spkg needs to wait for after Sage 4.3.2 is done.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:26

Please see #8167. If/when that ticket gets a positive review, I'll make 0.7.4...

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:27

I've posted SageNB 0.7.4 for review.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 The new spkg is at

-* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.3.spkg
+* http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.4.spkg

 Merged in 0.7: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

@@ -9,3 +9,5 @@
 Merged in 0.7.2:  #3083's "notruncate" patch.

 Merged in 0.7.3: #7784.
+
+Merged in 0.7.4: #8167, #8102, #8160.
34f90a52-c114-47db-a93b-3f83978622c0 commented 14 years ago
comment:28

Thanks for the update. But now I have too many sage notebooks

[marik@um-bc107 ../lib/python/site-packages]$ pwd
/opt/sage/local/lib/python/site-packages
[marik@um-bc107 ../lib/python/site-packages]$ ls -ld sagenb*
drwxr-xr-x 4 marik marik 4096  1. úno 17.16 sagenb-0.6-py2.6.egg
drwxr-xr-x 4 marik marik 4096  2. úno 19.33 sagenb-0.7.2-py2.6.egg
drwxr-xr-x 4 marik marik 4096  5. úno 09.13 sagenb-0.7.4-py2.6.egg

How do I know, which one is actually used? Jsmath image fonts failed to install intro correct directory. Should the old sage notebook be removed, first? Should this be tested on fresh install only?

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:29

We install the sagenb package with setuptools (PyPI), which updates SAGE_LOCAL/lib/python/site-packages/easy-install.pth. This file contains paths prepended to sys.path on startup.

You can query the installed version with

sage: from sagenb.misc.misc import SAGENB_VERSION
sage: SAGENB_VERSION

which is essentially

sage: from pkg_resources import Requirement, working_set
sage: w = working_set.find(Requirement.parse('sagenb'))
sage: w.version

Moreover, w.location gives the install directory.

I'm checking the fonts now...

6f4d16f1-6707-43c2-b378-bb8475bbf970 commented 14 years ago
comment:30

sagenb 0.7.4 installed correctly for me. All doc and selenium tests passed. Still problems building the PDF docs but Ihaven't applied any of the unicode patches (using vanilla sage-4.3.2.alpha1).

6f4d16f1-6707-43c2-b378-bb8475bbf970 commented 14 years ago

Changed reviewer from Robert Mařík, Minh Van Nguyen to Robert Mařík, Minh Van Nguyen, Alex Leone

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:31

On the fonts: What is the output of

egrep "Copying jsMath image"\|"Installed.*sagenb" $SAGE_ROOT/install.log

?

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:32

Replying to @sagetrac-acleone:

sagenb 0.7.4 installed correctly for me. All doc and selenium tests passed. Still problems building the PDF docs but Ihaven't applied any of the unicode patches (using vanilla sage-4.3.2.alpha1).

Positive review?

6f4d16f1-6707-43c2-b378-bb8475bbf970 commented 14 years ago
comment:33
$ egrep "Copying jsMath image"\|"Installed.*sagenb" ~/sage-dev/sage-4.3.2.alpha1/install.log
Installed /home/alex/sage-dev/sage-4.3.2.alpha1/local/lib/python2.6/site-packages/sagenb-0.6-py2.6.egg

Strange.

sage: from sagenb.misc.misc import SAGENB_VERSION
sage: SAGENB_VERSION
'0.7.4'

Here's how I installed:

  1. make on an unmodified 4.3.2.alpha1 

$ tar -jxvf sagenb-0.7.4.spkg
$ cd sagenb-0.7.4/src/sagenb/
$ sage -python setup.py develop

  1. Tested with sage -t -sagenb

  2. Selenium tests with sage -python sagenb/testing/run_tests.py

  3. Checking the PDF build with sage -docbuild all pdf

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:34

I think this is OK, because the SAGE_LOCAL/bin/sage-spkg script invoked by sage -f updates SAGE_ROOT/install.log but the sage -python setup.py commands do not.

6f4d16f1-6707-43c2-b378-bb8475bbf970 commented 14 years ago
comment:35

The "Use image fonts" option is disabled (greyed out) in jsMath - is this a problem?

jsMath v3.6c (Unicode fonts)

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:36

Are the image fonts installed? In twist.py, we set the boolean

jsmath_image_fonts = is_package_installed("jsmath-image-fonts")

which propagates to jsmath.js. This should enable the option if the spkg is installed. But the fonts need to be installed in the right place...

6f4d16f1-6707-43c2-b378-bb8475bbf970 commented 14 years ago
comment:37

Ok then, LGTM.

williamstein commented 14 years ago
comment:38

I decided to try something random to see if I was running the right notebook. So I tried #3154 first, and it appears that it is NOT fixed by this notebook upgrade. Other things I tried are fixed though.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -2,7 +2,7 @@

 * http://boxen.math.washington.edu/home/mpatel/trac/8051/sagenb-0.7.4.spkg

-Merged in 0.7: #7249, #7962, #7969, #3154, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.
+Merged in 0.7: #7249, #7962, #7969, #4217, #3083, #6182, #5263, #7631, #6353, #7207, #8000, #4450, #7848, #7963, #7752, #7996, #6475, #5675, #7435, #3844, #6368, #7434.

 Merged in 0.7.1: #8103.
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:40

It turns out that I merged #4217, not #3154, into SageNB 0.7. I didn't notice that #4217's commit string was copied from #3154 by mistake. I used hg log to make the list of merged tickets in the description.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Merged: sage-4.3.2