search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.36k stars 462 forks source link

eclib upgrade and bugfix #8184

Closed JohnCremona closed 14 years ago

JohnCremona commented 14 years ago

We provide an upgrade to eclib to patch-level 9, i.e. eclib-20080310.p9.spkg. This does two things:

  1. Fixes a bug (found by Edray Goins and Jamie Wiegandt) in which second descent quartics were not tested for real-solubility, and so sometimes the rank bounds (and related selmer ranks) could be too high.

  2. Enhances the data available from the two_descent class so that the rank_bound and selmer_rank are separated, and both available.

The second item necessitated changes to the interface, which are here included in the patch. In turn, some changes were needed in sage/schemes/elliptic_curve/

Note that this affects #7575.

Component: elliptic curves

Keywords: eclib

Author: John Cremona

Reviewer: Robert Miller

Merged: sage-4.3.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8184

JohnCremona commented 14 years ago

Attachment: eclib-20080310.p9.spkg.gz

chriswuthrich commented 14 years ago
comment:2

I fear you uploaded the wrong patch.

I am not certain how to review packages and I will read up on it; but someone might be faster at it.

Chris.

JohnCremona commented 14 years ago

Applies to 4.3.2.alpha1

JohnCremona commented 14 years ago
comment:3

Attachment: trac_8184-eclib.patch.gz

Sorry -- try this one.

NB After building the new spkg with "sage -f" the patch is required before Sage will work properly. Even in a clone, you'll be stuck with the new spkg. I am not sure how to revert back to the old eclib (if you want to).

So I would recommend tetsing this on (say) 4.3.2.alpha1 if you have it, and if all goes wrong you can build 4.3.2.rc0 which is out!

89c6e537-b2e3-45e6-882d-d4957b74ffe5 commented 14 years ago

Apply on top of trac_8184-eclib.patch

89c6e537-b2e3-45e6-882d-d4957b74ffe5 commented 14 years ago
comment:4

Attachment: trac_8184-indentation.patch.gz

I added a patch which replaces tabs with single spaces (it looks like your editor sees tabs as eight spaces... mine only sees them as four).

89c6e537-b2e3-45e6-882d-d4957b74ffe5 commented 14 years ago

Reviewer: Robert Miller

89c6e537-b2e3-45e6-882d-d4957b74ffe5 commented 14 years ago
comment:5

I've tested this on 32-bit OS X and 64-bit Linux, and there are no problems. Looks great!

chriswuthrich commented 14 years ago
comment:6

I knew someone would be faster. Thanks.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:7

The indentation patch seems to be missing the committer's name and email address, and the commit string does not contain the ticket number. I've refreshed the patch and applied it to 4.3.3.alpha0.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Merged: sage-4.3.3.alpha0