search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 462 forks source link

Complex conjugation in Galois groups #8493

Closed 11d1fc49-71a1-44e1-869f-76be013245a0 closed 14 years ago

11d1fc49-71a1-44e1-869f-76be013245a0 commented 14 years ago

The attached patch contains some simple code which will return the element of the Galois group of a number field corresponding to complex conjugation (at a specified complex place, or the "default" complex embedding where that exists).

The code also uses embeddings into QQbar, so I've moved QQbar over to the new coercion model (a simple case of renaming the __call__ method to _element_constructor_).

CC: @JohnCremona

Component: number fields

Keywords: Galois groups

Author: David Loeffler

Reviewer: John Cremona

Merged: sage-4.4.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/8493

11d1fc49-71a1-44e1-869f-76be013245a0 commented 14 years ago

Attachment: trac_8493-complex_conjugation.patch.gz

JohnCremona commented 14 years ago

Reviewer: John Cremona

JohnCremona commented 14 years ago
comment:2

Looks good, applies fine to 4.3.4.alpha1, and all tests pass.

JohnCremona commented 14 years ago

Author: David Loeffler

jhpalmieri commented 14 years ago
comment:3

This doesn't apply cleanly; it apparently conflicts with a patch merged into Sage 4.4.alpha0. Please rebase it against 4.4.alpha0 -- I don't think this will be too hard -- and we'll try hard to get this into 4.4.alpha1.

11d1fc49-71a1-44e1-869f-76be013245a0 commented 14 years ago

Attachment: trac_8493-complex_conjugation.2.patch.gz

now rebased against 4.4.alpha0

11d1fc49-71a1-44e1-869f-76be013245a0 commented 14 years ago
comment:5

The new patch is actually functionally identical to the old one -- it's only one of the "context" marker lines that has changed, due to another patch changing import statements in galois_group.py -- so I'm taking the liberty of setting it straight back to "positive_review".

David

JohnCremona commented 14 years ago
comment:6

I am happy with this (as original reviewer). I looked at the new patch, but have not tested it as I am still building 4.4.alpha0.

jhpalmieri commented 14 years ago
comment:7

Replying to @loefflerd:

I'm taking the liberty of setting it straight back to "positive_review".

I think that's fine. It applies cleanly to 4.4.alpha0; I'm checking doctests and will report if there are any problems. Otherwise, it will get merged into 4.4.alpha1.

jhpalmieri commented 14 years ago

Merged: sage-4.4.alpha1

jhpalmieri commented 14 years ago
comment:8

Merged "trac_8493-complex_conjugation.2.patch" into 4.4.alpha1