search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.39k stars 472 forks source link

Add support for rational polyhedral fans #8987

Closed novoselt closed 14 years ago

novoselt commented 14 years ago

This patch is a part of the following series adding support for cones/fans and toric varieties to Sage:

Prerequisites:

8675 - Remove AmbientSpace._constructor and fix consequences

8682 - Improve AlgebraicScheme_subscheme.__init__ and AmbientSpace._validate

8694 - Improve schemes printing and LaTeXing

8934 - Trivial bug in computing faces of non-full-dimensional lattice polytopes

8936 - Expose facet inequalities for lattice polytopes

8941 - _latex_ and origin for lattice polytopes

Main patches adding new modules:

9062 - Add support for toric lattices

8986 - Add support for convex rational polyhedral cones

8987 - Add support for rational polyhedral fans (this ticket now also has a bug fix #9188 as a prerequisite)

8988 - Add support for toric varieties

8989 - Add support for Fano toric varieties

Everything was tested on sage.math using sage-4.4.2.rc0.

CC: @vbraun @loefflerd

Component: geometry

Author: Andrey Novoseltsev

Reviewer: Volker Braun

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8987

novoselt commented 14 years ago

Attachment: trac_8987_repr_changes.patch.gz

Apply in the very end...

novoselt commented 14 years ago
comment:44

The last patch fixes printing. All doctests pass, coverage 100%. Ready for review, perhaps the final one!

I will now work on rebasing toric varieties modules on top of these.

vbraun commented 14 years ago
comment:45

I think the patch(es) are in great shape now. Positive review!

novoselt commented 14 years ago
comment:46

Thank you!

For the release manager: apply all patches in the order listed in the ticket.

novoselt commented 14 years ago

Attachment: trac_8987_cmp_fix.patch.gz

novoselt commented 14 years ago
comment:47

I made a systematic mistake in doctests of __cmp__ methods of all patches, discovered in #9062. So now I am posting these one-line patches to fix them, please review!

vbraun commented 14 years ago
comment:49

Looks good!

11d1fc49-71a1-44e1-869f-76be013245a0 commented 14 years ago
comment:50

This patch won't apply without #8986, which is currently at "needs work", so it can't be merged at present.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Merged: sage-4.5.2.alpha0

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:54

One or more of #8986, #8987, and #9062 may cause the doctest failures listed at #9590.