sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 482 forks source link

problem with converting FriCAS domains to Sage objects #9258

Closed cb6db86b-3b9b-456b-aef6-be35d93fcec6 closed 14 years ago

cb6db86b-3b9b-456b-aef6-be35d93fcec6 commented 14 years ago

Fricas seems to have an api change which breaks a few tests in fricas.py.

def _sage_domain(self):
        """
        A helper function for converting FriCAS domains to the corresponding
        Sage object.

        EXAMPLES::

            sage: fricas('Integer').sage() #optional - fricas
            Integer Ring
            sage: fricas('Fraction Integer').sage() #optional - fricas
            Rational Field
            sage: fricas('DoubleFloat').sage() #optional - fricas
            Real Double Field

        """

These now give either a different return value or simply results in raising a NotImplementedError.

Component: packages: optional

Author: Mike Hansen

Reviewer: Adam Webb

Merged: sage-4.5.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/9258

cb6db86b-3b9b-456b-aef6-be35d93fcec6 commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,8 @@
 Fricas seems to have an api change which breaks a few tests in fricas.py.

- -""" +def _sage_domain(self):

mwhansen commented 14 years ago
comment:2

Attachment: trac_9258.patch.gz

mwhansen commented 14 years ago

Author: Mike Hansen

cb6db86b-3b9b-456b-aef6-be35d93fcec6 commented 14 years ago

Reviewer: Adam Webb

cb6db86b-3b9b-456b-aef6-be35d93fcec6 commented 14 years ago
comment:3

That was easier than I thought it would be. :-)

Adam

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Merged: sage-4.5.2.alpha0