search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.38k stars 469 forks source link

Tracker bug for toric varieties #9604

Closed vbraun closed 5 years ago

vbraun commented 14 years ago

This bug tracks the current status of the toric varieties code and the interdependence of new patches.

Groups separated by blank lines may be applied independently.

CC: @novoselt

Component: algebraic geometry

Keywords: toric geometry

Author: Volker Braun, Andrey Novoseltsev

Issue created by migration from https://trac.sagemath.org/ticket/9604

vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,10 +1,11 @@
 This bug tracks the current status of the toric varieties code and the interdependence of new patches. The prerequisites are Sage 4.5.2.alpha0 (which should be equivalent to the 4.5.2 release).

-* #9470: Switch toric varieties to enhanced fans
-* #9326: Add cohomology of toric varieties
-* #9502: Basis parent bug in FreeModule
+* #9470: Switch toric varieties to enhanced fans **(positive review)**
+* #9326: Add cohomology of toric varieties **(positive review)**
+* #9502: Basis parent bug in `FreeModule`
 * #9504: Add support for toric sublattices
 * #9296: Add lattice computations for convex polyhedral cones
 * #9337: Toric divisors
+* #9664: Graphical representation of fans

-We expect the above to be ready for inclusion in Sage 5.0.
+We expect the above to be ready at the end of August.
e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:2

Can I merge #9470 and #9326 now, or should I wait until every ticket has a positive review?

vbraun commented 14 years ago
comment:3

9470 and #9326 are ready to be merged, but I thought that 4.5.2 is in feature freeze now?

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago
comment:4

Replying to @vbraun:

9470 and #9326 are ready to be merged, but I thought that 4.5.2 is in feature freeze now?

Indeed, we'll release 4.5.2 very soon. I've been preparing a 4.5.3.alpha0.

vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -2,10 +2,11 @@

 * #9470: Switch toric varieties to enhanced fans **(positive review)**
 * #9326: Add cohomology of toric varieties **(positive review)**
-* #9502: Basis parent bug in `FreeModule`
+* #9502: Basis parent bug in `FreeModule` **(positive review)**
 * #9504: Add support for toric sublattices
 * #9296: Add lattice computations for convex polyhedral cones
 * #9337: Toric divisors
+* #9713: Add the toric Chow group
 * #9664: Graphical representation of fans

 We expect the above to be ready at the end of August.
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -3,7 +3,7 @@
 * #9470: Switch toric varieties to enhanced fans **(positive review)**
 * #9326: Add cohomology of toric varieties **(positive review)**
 * #9502: Basis parent bug in `FreeModule` **(positive review)**
-* #9504: Add support for toric sublattices
+* #9504: Add support for toric sublattices **(positive review)**
 * #9296: Add lattice computations for convex polyhedral cones
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -4,7 +4,7 @@
 * #9326: Add cohomology of toric varieties **(positive review)**
 * #9502: Basis parent bug in `FreeModule` **(positive review)**
 * #9504: Add support for toric sublattices **(positive review)**
-* #9296: Add lattice computations for convex polyhedral cones
+* #9296: Add lattice computations for convex polyhedral cones **(positive review)**
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -5,6 +5,7 @@
 * #9502: Basis parent bug in `FreeModule` **(positive review)**
 * #9504: Add support for toric sublattices **(positive review)**
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
+* #9782: Enhanced fans fail for complicated cases
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -5,7 +5,7 @@
 * #9502: Basis parent bug in `FreeModule` **(positive review)**
 * #9504: Add support for toric sublattices **(positive review)**
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
-* #9782: Enhanced fans fail for complicated cases
+* #9782: Enhanced fans fail for complicated cases **(positive review)**
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
vbraun commented 14 years ago

updated patch

novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -6,6 +6,7 @@
 * #9504: Add support for toric sublattices **(positive review)**
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
 * #9782: Enhanced fans fail for complicated cases **(positive review)**
+* #9810: Heisenbug in RationalPolyhedralCone.facets
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago
comment:10

Attachment: toricvarieties.hg.gz

I'll put bugs in front of toric divisors, since they have chances to be settled quickly.

novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -6,7 +6,7 @@
 * #9504: Add support for toric sublattices **(positive review)**
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
 * #9782: Enhanced fans fail for complicated cases **(positive review)**
-* #9810: Heisenbug in RationalPolyhedralCone.facets
+* #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -7,6 +7,7 @@
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
 * #9782: Enhanced fans fail for complicated cases **(positive review)**
 * #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
+* #9812: Sorting bug in fan subdivision
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -7,7 +7,7 @@
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
 * #9782: Enhanced fans fail for complicated cases **(positive review)**
 * #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
-* #9812: Sorting bug in fan subdivision
+* #9812: Sorting bug in fan subdivision **(positive review)**
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago
comment:14

I sneaked in yet another patch in front of toric divisors, in case it will be useful for Kaehler/Mori cones (maybe not due to dimension limitations), but so far it is independent of #9337 and can be shifted down.

novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -8,6 +8,7 @@
 * #9782: Enhanced fans fail for complicated cases **(positive review)**
 * #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
 * #9812: Sorting bug in fan subdivision **(positive review)**
+* #9839: Add dual cone computation
 * #9337: Toric divisors
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -8,9 +8,7 @@
 * #9782: Enhanced fans fail for complicated cases **(positive review)**
 * #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
 * #9812: Sorting bug in fan subdivision **(positive review)**
-* #9839: Add dual cone computation
-* #9337: Toric divisors
+* #9839: Add dual cone computation **(positive review)**
+* #9337: Toric divisors (close to completion, includes #9380)
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
-
-We expect the above to be ready at the end of August.
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,7 +1,5 @@
-This bug tracks the current status of the toric varieties code and the interdependence of new patches. The prerequisites are Sage 4.5.2.alpha0 (which should be equivalent to the 4.5.2 release).
+This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.5.3. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

-* #9470: Switch toric varieties to enhanced fans **(positive review)**
-* #9326: Add cohomology of toric varieties **(positive review)**
 * #9502: Basis parent bug in `FreeModule` **(positive review)**
 * #9504: Add support for toric sublattices **(positive review)**
 * #9296: Add lattice computations for convex polyhedral cones **(positive review)**
@@ -9,6 +7,7 @@
 * #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
 * #9812: Sorting bug in fan subdivision **(positive review)**
 * #9839: Add dual cone computation **(positive review)**
-* #9337: Toric divisors (close to completion, includes #9380)
+* #9337: Toric divisors **(positive review, includes #9380)**
+
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,13 +1,6 @@
-This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.5.3. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."
+This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.6.alpha1. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

-* #9502: Basis parent bug in `FreeModule` **(positive review)**
-* #9504: Add support for toric sublattices **(positive review)**
-* #9296: Add lattice computations for convex polyhedral cones **(positive review)**
-* #9782: Enhanced fans fail for complicated cases **(positive review)**
-* #9810: Heisenbug in `RationalPolyhedralCone.facets` **(positive review)**
-* #9812: Sorting bug in fan subdivision **(positive review)**
-* #9839: Add dual cone computation **(positive review)**
-* #9337: Toric divisors **(positive review, includes #9380)**
+* #9934: Toric divisor class -> divisor lift should be integral **(positive review)**

 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,6 +1,17 @@
 This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.6.alpha1. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

 * #9934: Toric divisor class -> divisor lift should be integral **(positive review)**
+* #9963: non-nef divisors can have sections, too
+
+
+Needs more work:

 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
+
+
+The following two patches will probably become prerequisites at one point:
+
+* #9798: accelerate Polyhedron
+* #9918: triangulate point configurations
+
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,7 +1,7 @@
 This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.6.alpha1. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

 * #9934: Toric divisor class -> divisor lift should be integral **(positive review)**
-* #9963: non-nef divisors can have sections, too
+* #9963: non-nef divisors can have sections, too **(positive review)**

 Needs more work:
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -2,7 +2,7 @@

 * #9934: Toric divisor class -> divisor lift should be integral **(positive review)**
 * #9963: non-nef divisors can have sections, too **(positive review)**
-
+* #9972: Add toric lattice morphisms

 Needs more work:
vbraun commented 14 years ago

Author: Volker Braun, Andrey Novoseltsev

vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -6,6 +6,8 @@

 Needs more work:

+* #10021: Empty LatticePolytope fails
+* #10022: Cone.is_smooth() returns wrong answer
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans

@@ -15,3 +17,6 @@
 * #9798: accelerate Polyhedron
 * #9918: triangulate point configurations

+Depending on them:
+
+* #10023: Compute Hilbert basis of cone
vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -2,12 +2,12 @@

 * #9934: Toric divisor class -> divisor lift should be integral **(positive review)**
 * #9963: non-nef divisors can have sections, too **(positive review)**
+* #10021: Empty `LatticePolytope` fails
+* #10022: `Cone.is_smooth()` returns wrong answer
 * #9972: Add toric lattice morphisms

 Needs more work:

-* #10021: Empty LatticePolytope fails
-* #10022: Cone.is_smooth() returns wrong answer
 * #9713: Add the toric Chow group
 * #9664: Graphical representation of fans
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -2,14 +2,14 @@

 * #9934: Toric divisor class -> divisor lift should be integral **(positive review)**
 * #9963: non-nef divisors can have sections, too **(positive review)**
-* #10021: Empty `LatticePolytope` fails
-* #10022: `Cone.is_smooth()` returns wrong answer
+* #10021: Empty `LatticePolytope` fails **(positive review)**
+* #10022: `Cone.is_smooth()` returns wrong answer **(positive review)**
 * #9972: Add toric lattice morphisms

 Needs more work:

 * #9713: Add the toric Chow group
-* #9664: Graphical representation of fans
+* #9664: Graphical representation of fans (in progress...)

 The following two patches will probably become prerequisites at one point:
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -4,13 +4,12 @@
 * #9963: non-nef divisors can have sections, too **(positive review)**
 * #10021: Empty `LatticePolytope` fails **(positive review)**
 * #10022: `Cone.is_smooth()` returns wrong answer **(positive review)**
-* #9972: Add toric lattice morphisms
+* #9664: Graphical representation of fans

 Needs more work:

+* #9972: Add toric lattice morphisms
 * #9713: Add the toric Chow group
-* #9664: Graphical representation of fans (in progress...)
-

 The following two patches will probably become prerequisites at one point:
vbraun commented 14 years ago
comment:25

trac_9664_add_toric_potter.patch depends on trac_9972_add_toric_lattice_morphisms.patch. No logical dependency, but thats how the patch works out. I don't think order matters too much on that one, just wanted to get it right.

vbraun commented 14 years ago

Description changed:

--- 
+++ 
@@ -4,11 +4,11 @@
 * #9963: non-nef divisors can have sections, too **(positive review)**
 * #10021: Empty `LatticePolytope` fails **(positive review)**
 * #10022: `Cone.is_smooth()` returns wrong answer **(positive review)**
-* #9664: Graphical representation of fans

-Needs more work:
+Currently working on:

 * #9972: Add toric lattice morphisms
+* #9664: Graphical representation of fans
 * #9713: Add the toric Chow group

 The following two patches will probably become prerequisites at one point:
novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,14 +1,16 @@
 This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.6.alpha1. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

-* #9934: Toric divisor class -> divisor lift should be integral **(positive review)**
-* #9963: non-nef divisors can have sections, too **(positive review)**
-* #10021: Empty `LatticePolytope` fails **(positive review)**
-* #10022: `Cone.is_smooth()` returns wrong answer **(positive review)**
+**Positively reviewed:**
+
+* #9934: Toric divisor class -> divisor lift should be integral
+* #9963: non-nef divisors can have sections, too
+* #10021: Empty `LatticePolytope` fails
+* #10022: `Cone.is_smooth()` returns wrong answer

 Currently working on:

+* #9664: Graphical representation of fans
 * #9972: Add toric lattice morphisms
-* #9664: Graphical representation of fans
 * #9713: Add the toric Chow group

 The following two patches will probably become prerequisites at one point:
novoselt commented 14 years ago
comment:26

No more dependence ;-)

novoselt commented 14 years ago

Description changed:

--- 
+++ 
@@ -6,10 +6,10 @@
 * #9963: non-nef divisors can have sections, too
 * #10021: Empty `LatticePolytope` fails
 * #10022: `Cone.is_smooth()` returns wrong answer
+* #9664: Graphical representation of fans

 Currently working on:

-* #9664: Graphical representation of fans
 * #9972: Add toric lattice morphisms
 * #9713: Add the toric Chow group
novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -1,12 +1,8 @@
-This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied on top of Sage 4.6.alpha1. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."
+This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied **on top of Sage 4.6.** Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

 **Positively reviewed:**

-* #9934: Toric divisor class -> divisor lift should be integral
-* #9963: non-nef divisors can have sections, too
-* #10021: Empty `LatticePolytope` fails
-* #10022: `Cone.is_smooth()` returns wrong answer
-* #9664: Graphical representation of fans
+* None at the moment

 Currently working on:

@@ -15,7 +11,6 @@

 The following two patches will probably become prerequisites at one point:

-* #9798: accelerate Polyhedron
 * #9918: triangulate point configurations

 Depending on them:
novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -6,6 +6,7 @@

 Currently working on:

+* #10237: Polyhedra of trivial cones are wrong
 * #9972: Add toric lattice morphisms
 * #9713: Add the toric Chow group
novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -2,11 +2,13 @@

 **Positively reviewed:**

-* None at the moment
+* #10237: Polyhedra of trivial cones are wrong
+* #9954: `f_vector` outputs an extra top-dimensional cell
+* #8656: 'face_lattice` does not seem to work for unbounded polyhedra

 Currently working on:

-* #10237: Polyhedra of trivial cones are wrong
+* #10238: Containment checks are wrong for empty polyhedra
 * #9972: Add toric lattice morphisms
 * #9713: Add the toric Chow group
novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -5,10 +5,10 @@
 * #10237: Polyhedra of trivial cones are wrong
 * #9954: `f_vector` outputs an extra top-dimensional cell
 * #8656: 'face_lattice` does not seem to work for unbounded polyhedra
+* #10238: Containment checks are wrong for empty polyhedra

 Currently working on:

-* #10238: Containment checks are wrong for empty polyhedra
 * #9972: Add toric lattice morphisms
 * #9713: Add the toric Chow group
novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -1,21 +1,16 @@
-This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied **on top of Sage 4.6.** Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."
+This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied **on top of Sage 4.6.1.alpha1** Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

 **Positively reviewed:**

-* #10237: Polyhedra of trivial cones are wrong
-* #9954: `f_vector` outputs an extra top-dimensional cell
-* #8656: 'face_lattice` does not seem to work for unbounded polyhedra
-* #10238: Containment checks are wrong for empty polyhedra
+* #9972: Add fan morphisms

 Currently working on:

-* #9972: Add toric lattice morphisms
+* #10039: Make Parma Polyhedra Library a standard library
+* #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
 * #9713: Add the toric Chow group

-The following two patches will probably become prerequisites at one point:
+And then:

 * #9918: triangulate point configurations
-
-Depending on them:
-
 * #10023: Compute Hilbert basis of cone
vbraun commented 13 years ago

Description changed:

--- 
+++ 
@@ -6,8 +6,10 @@

 Currently working on:

+* #10233: Incomplete cython search path in setup.py
 * #10039: Make Parma Polyhedra Library a standard library
 * #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
+* #10325: Cohomology Ring of toric varieties not unique
 * #9713: Add the toric Chow group

 And then:
novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -3,14 +3,15 @@
 **Positively reviewed:**

 * #9972: Add fan morphisms
+* #10325: Cohomology Ring of toric varieties not unique

 Currently working on:

 * #10233: Incomplete cython search path in setup.py
 * #10039: Make Parma Polyhedra Library a standard library
 * #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
-* #10325: Cohomology Ring of toric varieties not unique
 * #9713: Add the toric Chow group
+* #10336: Cannot plot non-strictly convex cones

 And then:
vbraun commented 13 years ago

Description changed:

--- 
+++ 
@@ -4,6 +4,8 @@

 * #9972: Add fan morphisms
 * #10325: Cohomology Ring of toric varieties not unique
+* #10355: containment for multivariate polynomial rings (requirement for #10498)
+* #10498: fix inject_coefficients for toric varieties

 Currently working on:
vbraun commented 13 years ago

Description changed:

--- 
+++ 
@@ -6,6 +6,7 @@
 * #10325: Cohomology Ring of toric varieties not unique
 * #10355: containment for multivariate polynomial rings (requirement for #10498)
 * #10498: fix inject_coefficients for toric varieties
+* #10336: Cannot plot non-strictly convex cones

 Currently working on:

@@ -13,7 +14,6 @@
 * #10039: Make Parma Polyhedra Library a standard library
 * #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
 * #9713: Add the toric Chow group
-* #10336: Cannot plot non-strictly convex cones

 And then:
simon-king-jena commented 13 years ago

Description changed:

--- 
+++ 
@@ -13,6 +13,7 @@
 * #10233: Incomplete cython search path in setup.py
 * #10039: Make Parma Polyhedra Library a standard library
 * #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
+* #10513: Coercion and category framework for modules
 * #9713: Add the toric Chow group

 And then:
simon-king-jena commented 13 years ago

Description changed:

--- 
+++ 
@@ -13,7 +13,6 @@
 * #10233: Incomplete cython search path in setup.py
 * #10039: Make Parma Polyhedra Library a standard library
 * #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
-* #10513: Coercion and category framework for modules
 * #9713: Add the toric Chow group

 And then:
simon-king-jena commented 13 years ago
comment:39

Sorry for temporarily making #10513 a dependency. This ticket isn't ready, yet. Thus I reoved the dependency again.

novoselt commented 13 years ago
comment:40

Tried to make all dependencies and especially their absences more clear.

Volker, I am a little confused by comments on #8169 and #9918 - do they depend on/conflict with each other somehow?

novoselt commented 13 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied **on top of Sage 4.6.1.alpha1** Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."
+This bug tracks the current status of the toric varieties code and the interdependence of new patches, which should be applied **on top of Sage 4.6.1.alpha3**. Any (properly ordered) part of positively reviewed patches can be merged at any time, there is no need to "bundle tickets."

 **Positively reviewed:**

@@ -8,14 +8,17 @@
 * #10498: fix inject_coefficients for toric varieties
 * #10336: Cannot plot non-strictly convex cones

-Currently working on:
+These needs-review groups (separated by blank lines) can be applied independently on top of the positively reviewed ones:
+
+* #9713: Add the toric Chow group
+
+* #10479: Nef-partitions rewrite
+
+* #8169: include TOPCOM as optional spkg
+
+* #9918: triangulate point configurations
+* #10023: Compute Hilbert basis of cone

 * #10233: Incomplete cython search path in setup.py
 * #10039: Make Parma Polyhedra Library a standard library
 * #10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
-* #9713: Add the toric Chow group
-
-And then:
-
-* #9918: triangulate point configurations
-* #10023: Compute Hilbert basis of cone
vbraun commented 13 years ago
comment:41

9918 uses the TOPCOM spkg (in #8169) if it is available, and falls back to its own implementation if not. So there is no dependency either way. Except that applying #8169 without #9918 would be meaningless as there would be nothing in the sage library to use TOPCOM.

novoselt commented 13 years ago
comment:42

So none of the patches of #8169 should be applied, it just provides an optional package, correct?

vbraun commented 13 years ago
comment:43

Yes, none of the patches in #8169 should be applied.