Upgrade to Cython 0.13 - Githubissues

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.44k stars 481 forks source link

Upgrade to Cython 0.13 #9828

Closed e14f4152-4982-4ace-8c95-73a0599b109b closed 14 years ago

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Here are the release notes for Cython 0.13.

Apply

http://sage.math.washington.edu/home/robertwb/cython/cython-0.13.p1.spkg
http://sage.math.washington.edu/home/mpatel/trac/10036/sagenb-0.8.5.spkg (#10036's SageNB 0.8.5 package).
attachment: trac_9828-cython_0_13.patch to the sage repository.
attachment: trac_9828-scripts_hudson.patch to the scripts repository.

CC: @robertwb @nexttime @jasongrout @craigcitro @TimDumol @qed777

Component: packages: standard

Author: Robert Bradshaw, Craig Citro, Leif Leonhardy

Reviewer: Jason Grout, Leif Leonhardy, Mitesh Patel

Merged: sage-4.6.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/9828

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

comment:38

The long doctests pass for me on sage.math with 4.6.alpha2 + the spkgs and patches in the description.

If no one objects, I'm giving this a positive review. Can someone please review #10036 soon?

By the way, does XML_RESULTS = os.environ.get('XML_RESULTS', None) internally do the same as

try:
    XML_RESULTS = os.environ['XML_RESULTS']
except KeyError:
    XML_RESULTS = None

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Description changed:

--- 
+++ 
@@ -4,7 +4,7 @@

 * http://sage.math.washington.edu/home/robertwb/cython/cython-0.13.p1.spkg

-* http://sage.math.washington.edu/home/mpatel/trac/10036/sagenb-0.8.5.spkg
+* http://sage.math.washington.edu/home/mpatel/trac/10036/sagenb-0.8.5.spkg (#10036's SageNB 0.8.5 package).

 * [attachment: trac_9828-cython_0_13.patch](https://github.com/sagemath/sage-prod/files/10650658/trac_9828-cython_0_13.patch.gz) to the sage repository.

e14f4152-4982-4ace-8c95-73a0599b109b commented 14 years ago

Merged: sage-4.6.alpha3

jasongrout commented 14 years ago

comment:41

Replying to @qed777:

The long doctests pass for me on sage.math with 4.6.alpha2 + the spkgs and patches in the description.

If no one objects, I'm giving this a positive review. Can someone please review #10036 soon?

By the way, does XML_RESULTS = os.environ.get('XML_RESULTS', None) internally do the same as
try:
    XML_RESULTS = os.environ['XML_RESULTS']
except KeyError:
    XML_RESULTS = None
?

Yes. See http://docs.python.org/library/stdtypes.html#dict.get

robertwb commented 14 years ago

comment:42

Replying to @qed777:

The long doctests pass for me on sage.math with 4.6.alpha2 + the spkgs and patches in the description.

If no one objects, I'm giving this a positive review.

Thanks all! Next up, Cython 0.13.1 :) I'm neither planning to wait as long nor make as many changes, so it won't be near as bad...

Can someone please review #10036 soon?

By the way, does XML_RESULTS = os.environ.get('XML_RESULTS', None) internally do the same as
try:
    XML_RESULTS = os.environ['XML_RESULTS']
except KeyError:
    XML_RESULTS = None
?

Yes, that would have probably been cleaner.

jasongrout commented 14 years ago

comment:43

Replying to @robertwb:

By the way, does XML_RESULTS = os.environ.get('XML_RESULTS', None) internally do the same as
try:
    XML_RESULTS = os.environ['XML_RESULTS']
except KeyError:
    XML_RESULTS = None
?
Yes, that would have probably been cleaner.

Since None is the default default value, it could even be shortened to XML_RESULTS = os.environ.get('XML_RESULTS')

jdemeyer commented 5 years ago

comment:44

What is the purpose of this XML_RESULTS stuff which was introduced here?