search

sagemath / sage_sample

A sample project illustrating how to write and distribute SageMath extensions
GNU General Public License v2.0
17 stars 15 forks source link

don't use --no-index during make install #21

Closed koffie closed 1 year ago

koffie commented 7 years ago

The --no-index tells pip that it is not allowed to look on pypi for packages, but this is bad since it doesn't allow for pip to automatically install requirements

koffie commented 7 years ago

@williamstein @nthiery @mmasdeu How is development of this package currently organised? I would like to contribute to this package, since it seems that there is a lot that can be improved. However it doesn't seem like there is a lot of activity going on here, and that important pull request are not getting merged. I mean important other open pull requests like adding cython support, and refactoring to avoid code duplication.

nthiery commented 7 years ago 
    Dear Marteen,

On Mon, Sep 04, 2017 at 04:59:40PM -0700, Maarten Derickx wrote:

[1]@williamstein [2]@nthiery [3]@mmasdeu How is development of this package currently organised? I would like to contribute to this package, since it seems that there is a lot that can be improved. However it doesn't seem like there is a lot of activity going on here, and that important pull request are not getting merged. I mean like other open pull requests like adding cython support, and refactoring to avoid code duplication.

Thanks for raising that point. And for all the propositions for improvements!

So far, the development is organized by, err, sprints; outside of which people indeed don't have much time to contribute / manage.

My personal perspective: the goal of this package is to provide a central point where to collect all the ideas and try various approaches. I believe it's best to remain agile and rather informal in its development: have a large pool of devs with direct write access; direct pushes for anything non controversial, and pull requests to be merged by anyone else in the pool for things that deserve more discussion.

The building of a cookie cutter will be the occasion to select and polish exactly which feature we want.

Cheers, Nicolas

koffie commented 7 years ago

Hi Nicolas,

Thanks for the explaining, I do have some time to work on this right now and plan to do so. Could you give me write acces to this repository and the [sage-package https://github.com/sagemath/sage-package]? I indeed think that the rather informal development model makes sense.

In order to be able to move forward quickly here is how I propose to proceed with the changes that I will make.

1) push all non-controversial changes directly to master 2) create feature branches for possibly controversial features. 3) make a develop branch in which I merge all feature branches that I find useful, including the possible controversial ones. And make sure that the develop branch remains in a working state. 4) document in README.rst that the develop branch contains significantly more features.

Does this sound sensible?

nthiery commented 7 years ago

On Tue, Sep 05, 2017 at 03:27:10PM +0000, Maarten Derickx wrote:

Thanks for the explaining, I do have some time to work on this right now and plan to do so. Could you give me write acces to this repository and the [sage-package https://github.com/sagemath/sage-package]? I indeed think that the rather informal development model makes sense.

Invitation sent; welcome on board! I am glad to see more manpower in this direction; thanks.

In order to be able to move forward quickly here is how I propose to proceed with the changes that I will make.

  1. push all non-controversial changes directly to master
  2. create feature branches for possibly controversial features.
  3. make a develop branch in which I merge all feature branches that I find useful, including the possible controversial ones. And make sure that the develop branch remains in a working state.

  4. document in README.rst that the develop branch contains significantly more features.

    Does this sound sensible?

Sounds good to me. Opinions anyone?

seblabbe commented 1 year ago

I am currently at Sage Days 117. There was a demo earlier this week on how to share code and create a package where we used sage_sample. We ran into the issue of make install which can't install the dependencies. Let's merge this branch.

I will take a look at the other PR now.

nthiery commented 1 year ago

Hi @seblabbe,

Good to see some action around sage_sample. It certainly needs some updates and love, and I personally don't have energy in this direction. Feel free to take over as appropriate!

Enjoy Sage Days 117 :-)