search

sagemath / sagecell

The Sage Cell Server---providing a way to embed Sage computations into any web page.
Other
201 stars 70 forks source link

Complete ES Module Switch #553

Closed siefkenj closed 2 years ago

siefkenj commented 2 years ago

This PR is based on #552 It completes the transition to ES modules by removing the define statements. The diffs look large because of indentation changes, but the actual changes are very small.

siefkenj commented 2 years ago

@novoselt This should be ready now. The changes to code are minimal. It's mainly switching from define(...) to export ....

I also added eslint. This is for development only. By default it's not turned on unless there is a .eslintrc. I'm not sure what rules you want in it by default, so I didn't add .eslintrc, but it's really helpful for finding Javascript errors and enforcing style guidelines.

novoselt commented 2 years ago

Deployed and seems to work fine so far!