search

sagemath / sagenb

Sage Notebook (flask), docs in $SAGE_LOCAL/share/doc/sagenb/index.html
Other
116 stars 97 forks source link

some care for imports (for python3) #446

Closed fchapoton closed 6 years ago

fchapoton commented 6 years ago

because this is causing a failure in sage3 documentation build

BEWARE : I have no idea if this works or not..

see https://patchbot.sagemath.org/log/0/Ubuntu/18.04/x86_64/4.15.0-20-generic/petitbonum/2018-06-11%2009:26:28?plugin=docbuild

fchapoton commented 6 years ago

It seems that this works correctly (sagenb starts and works), but I have no clear idea on how to test the replacement of sgml-parser by html-parser.

fchapoton commented 6 years ago

hmm. it seems that this is involved in live documentation. And live documentation is not working with this branch. Is it working in the current sagenb ?

fchapoton commented 6 years ago

found another obsolete import in the same file

kcrisman commented 6 years ago

With the latest beta I do not seem to have functioning live documentation (though it is there, it just doesn't evaluate, though new cells etc. work - not connected to Sage itself, just the html works, I guess). One would want to see who the user is for those right now; I don't see any error messages, anyway. There is also an extra — in live doc worksheet names for some reason, which I guess is a bad parsing of an old em-dash or something.

kcrisman commented 6 years ago

Also true in Sage 8.2.

fchapoton commented 6 years ago

OK. I have undone the change from SGML Parser to HTML Parser, as this was breaking the live documentation. All what remains in this pull request are trivial changes in imports, some of which are useful towards python3 compatibility. I have check that all notebook tests do pass.

fchapoton commented 6 years ago

ping ?

fchapoton commented 6 years ago

Erik or Dima, would you have time to look at (and hopefully merge) my 3 pull requests here, please ? They should be rather easy to review, I think.

Once done (if you agree), I would then like to make a new release of sagenb, in order to enable the upgrade of flask.