search

sagemath / trac-to-github

Script to migrate Trac tickets to GitHub issues and the Trac wiki to markdown. Input: https://trac.sagemath.org/ ➠ Intermediate: https://github.com/sagemath/trac_to_gh ➠ Output: https://github.com/sagemath/sage/issues
https://trac.sagemath.org/ticket/30363
7 stars 5 forks source link

Add comment number to issue comments #109

Closed kwankyu closed 1 year ago

kwankyu commented 1 year ago

Apart from the last line in the changes for the issue #107, other changes are just refactoring to clean up things.

kwankyu commented 1 year ago

Though the comment links are rewritten to use the fragment URL, at least on some tickets, ticket comments refer to earlier ticket comments by number without using the correct format.

Now I understand this. So the comment numbers are useful.

But perhaps if it is followed by the "Replying to [...]" message, the "\n" can be suppressed?

I don't know. But perhaps we should be consistent...

Let's see how the comment numbers are shown in GES.

mkoeppe commented 1 year ago

I think there's no need to keep the format "comment:123" because we replace all occurrences of this format when it appears in links. How about "Comment 123:"?

kwankyu commented 1 year ago

The converted issues in GES look somewhat different than in migration archive. Let's see how it looks.

kwankyu commented 1 year ago

Will we see all tickets in GES soon?

mkoeppe commented 1 year ago

Will we see all tickets in GES soon?

Yes, the conversion is running. It's taking quite a few hours for the full run. It's at 70% now...

kwankyu commented 1 year ago

Could we see some converted issues with comment numbers in GES by a run separate from the current full run?