search

sagemath / trac-to-github

Script to migrate Trac tickets to GitHub issues and the Trac wiki to markdown. Input: https://trac.sagemath.org/ ➠ Intermediate: https://github.com/sagemath/trac_to_gh ➠ Output: https://github.com/sagemath/sage/issues
https://trac.sagemath.org/ticket/30363
7 stars 5 forks source link

Try again to fine-tune comment number #137

Closed kwankyu closed 1 year ago

kwankyu commented 1 year ago

Second try to fix #121.

kwankyu commented 1 year ago

Two newlines is the trick.

kwankyu commented 1 year ago

I am not sure whether "Comment 18" is in right format since some links in text (as seen in https://34.105.185.241/sagemath/sage-20230114144245/issues/33453#issuecomment-1495703) still refer to it by "comment:18". Following the trac format seems better for consistency.

kwankyu commented 1 year ago

Another instance of the trac form is seen in #138.

mkoeppe commented 1 year ago

Thanks!

mkoeppe commented 1 year ago

It's live at https://34.105.185.241/sagemath/sage-20230116133759/issues/34230

Looking very good.

I wouldn't mind a change of it to the format "comment:18" if you prefer that, or a change of the link text to "comment 18" for consistency.