Closed kwankyu closed 1 year ago
Apart from this PR, I have a question. There are many ".patch" file attachments, like https://34.105.185.241/sagemath/sage-all-2023-01-14-015/issues/9516#issuecomment-5696823. Couldn't these be of "text/plain" mime type, so that ".gz" extension is unnecessary? And ".diff" files too.
After looking through many more converted issues, I hopefully expect that this PR is my last one.
There are many ".patch" file attachments, like https://34.105.185.241/sagemath/sage-all-2023-01-14-015/issues/9516#issuecomment-5696823. Couldn't these be of "text/plain" mime type, so that ".gz" extension is unnecessary? And ".diff" files too.
The importer is very picky about file name extensions and declared mime types matching, and it appears to have a fixed set of those pairs that it accepts. It does not accept the .diff
and .patch
extensions -- neither as "text/plain" nor as "application/octet-stream". That's why I am using compression as a workaround. An alternative would have been to append ".txt" as an additional filename extension and to declare it "text/plain", but I prefer the ".gz" solution.
Thanks a lot!
OK. Thank you!
There is another form of ticket-comment links, seen in
https://34.105.185.241/sagemath/sage-all-2023-01-14-015/issues/9512#issuecomment-5696801
(compare with https://trac.sagemath.org/ticket/9512#comment:5 and https://github.com/kwankyu/trac-to-github/blob/check/wiki/Issues-09xxx/9512.md#comment:5). There are lots of these broken links.