search

sagemath / trac-to-github

Script to migrate Trac tickets to GitHub issues and the Trac wiki to markdown. Input: https://trac.sagemath.org/ ➠ Intermediate: https://github.com/sagemath/trac_to_gh ➠ Output: https://github.com/sagemath/sage/issues
https://trac.sagemath.org/ticket/30363
7 stars 5 forks source link

Fix line breaks #160

Closed kwankyu closed 1 year ago

kwankyu commented 1 year ago

Seen in https://34.105.185.241/sagemath/sage-all-2023-01-14-015/issues/8156#issuecomment-5677548 (compare with https://trac.sagemath.org/ticket/8156#comment:15).

I removed the phrase "that was inherited from the migration" from "This is the Trac macro ** that was inherited from the migration", which seems unnecessary and just makes the sentence long.

kwankyu commented 1 year ago

Checking any regression to be sure.

kwankyu commented 1 year ago

As far as I could check, there is no regression.

With better conversion of line breaks [[br]] and \\, the conversion is better.

Often times, a better conversion of wrong-formatted text may actually get worse.

mkoeppe commented 1 year ago

Excellent, thanks very much. I have inspected the diff and looked at a number of the generated .md files. I agree there's no regression, and in fact this is a great improvement.

Often times, a better conversion of wrong-formatted text may actually get worse.

Yes, I've seen a few of these, but I don't think that's a problem.