sagemath / trac-to-github

Script to migrate Trac tickets to GitHub issues and the Trac wiki to markdown. Input: https://trac.sagemath.org/ ➠ Intermediate: https://github.com/sagemath/trac_to_gh ➠ Output: https://github.com/sagemath/sage/issues
https://trac.sagemath.org/ticket/30363
7 stars 5 forks source link

Fix commits list problem #171

Closed kwankyu closed 1 year ago

kwankyu commented 1 year ago

Seen in https://34.105.185.241/sagemath/sage-prod-2023-01-30-077/issues/34956#issuecomment-7308003

Checking regression...

kwankyu commented 1 year ago

Affected cases should be very rare.

It takes me long to check regression. Would you check?

kwankyu commented 1 year ago

Affected cases should be very rare.

No, there are many cases. In all those cases, our converter seems smarter than Trac, as seen in

-I made a change like this, but changing `2008`} to `{2008`}}.  The second brace } matches the one a few lines earlier, in the line `@manual{sage`.  (The change wasn't really necessary, but it doesn't hurt, either.)
+I made a change like this, but changing `2008}` to `{2008}}`.  The second brace } matches the one a few lines earlier, in the line `@manual{sage`.  (The change wasn't really necessary, but it doesn't hurt, either.) 

for trac #1389

mkoeppe commented 1 year ago

Yes, I just ran it and there's a long long diff. pr171.diff.gz

I'll try to find time this evening to review it

kwankyu commented 1 year ago

I checked through the diff file. There are two cases:

I definitely recommend to take this PR.

mkoeppe commented 1 year ago

I agree, looking good. Thank you!

kwankyu commented 1 year ago

Thanks!