sagemath / website

Source for https://www.sagemath.org/; submit Issues/PRs here to update the website
40 stars 180 forks source link

Developer map: Display Trac account name, improve search #313

Closed mkoeppe closed 1 year ago

mkoeppe commented 1 year ago

Also adds an altnames attribute (comma-separated) and allows trac to be a comma-separated list @kwankyu

kwankyu commented 1 year ago

I didn't test, but you may need

--- a/scripts/geocode.py
+++ b/scripts/geocode.py
@@ -157,6 +157,7 @@ def writeToDevmap():
             tracQuery += f"&or&author=~{name}"
             tracQuery += f"&or&reviewer=~{name}"
         tracQuery += "&max=500&col=id&col=summary&col=author&col=status&col=priority&col=milestone&col=reviewer&order=priority"
+        tracQuery = tracQuery.replace(" ", "%20")
         a.setAttribute("href", tracQuery)
         a.setAttribute("class", "trac")
         if main_trac:

as names contain spaces.

mkoeppe commented 1 year ago

Yes, that's better, thanks.

mkoeppe commented 1 year ago

(I've tested with make devmap and then opening templates/devs.html in the browser)

kwankyu commented 1 year ago

I cannot approve this, perhaps because I don't have write access.

mkoeppe commented 1 year ago

I think this is something that we need to figure out in general for the github transition - how to configure reviews, project membership, and teams

kwankyu commented 1 year ago

Thanks, Harald!