search

sagemath / website

Source for https://www.sagemath.org/; submit Issues/PRs here to update the website
40 stars 180 forks source link

contributors.xml: Add contributors G* from sage-changelogs #347

Closed mkoeppe closed 1 year ago

mkoeppe commented 1 year ago

@kwankyu

kwankyu commented 1 year ago

There are 687 contributors in the changelogs missing in contributors.xml.

Are you adding all of them, manually, from A to Z?

My script can do it at once. Do you want me to do that? I asked this before but you didn't answer. So I thought you were -1 in doing this...

mkoeppe commented 1 year ago

Sorry, I must have missed this! Yes, +1 for using your script to do it all!

kwankyu commented 1 year ago

All of 687 names of the changelog do not seem to appear in the current contributors.xml. This is strange to me. Is this reasonable?

kwankyu commented 1 year ago

Sorry I must be doing something wrong, obviously.

mkoeppe commented 1 year ago

My script contributors-from-sage-changelogs.py also gives this number of 687 missing names.

kwankyu commented 1 year ago

Right. There are much more names in the changelog than that. I was confused.

kwankyu commented 1 year ago

The script is not quite correct. See

python3 contributors-from-sage-changelogs.py | grep 'Bissey'
 name="Francois Bissey"/>

My new count is 655.

mkoeppe commented 1 year ago

Yes, my script makes no attempt to normalize names. I had planned to add the alternate spellings as altnames attributes

kwankyu commented 1 year ago

I made PR #350.

This PR may be closed.