search

sagemathinc / cocalc-docker

DEPRECATED (was -- Docker setup for running CoCalc as downloadable software on your own computer)
https://cocalc.com
Other
398 stars 103 forks source link

Registration Token not required #135

Closed giacomogallina closed 2 years ago

giacomogallina commented 2 years ago

Hi, i installed cocalc-docker earlier today and i noticed that the registration token was not required to create an account, but only email, password, first name and last name. I tried changing the "allow email signup", creating another token, restarting the container, and changing the container version from 02a4436cb62c to latest, but the registration token was still ignored. What did work was downgrading the image to 8d6dbc1e2bf0 (the one just before 02a4436cb62c): in this image, there isn't the sign up link at the top of the homepage, and the sign up page is very different from the one in 02a4436cb62c, but there is a working registration token field! So, i guess that one of the last commits accidentally removed the need for the registration tokens?

williamstein commented 2 years ago

The entire sign up process was completely rewritten from scratch. Evidently we forgot about the registration token, which isn't used on cocalc.com, but is used of course on many cocalc-docker. I'll delete the latest cocalc-docker image with this new rewrite, then make sure to implement registration tokens soon...

williamstein commented 2 years ago

OK, the recent cocalc-docker images with this missing feature are now deleted.

giacomogallina commented 2 years ago

Great, thank you for the quick reply!

williamstein commented 2 years ago

I pushed a new image that should have registration token implemented properly.

giacomogallina commented 2 years ago

Thank you, you've been super fast and the new image works perfectly!