links to smc-in-smc are not properly detected

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud

https://CoCalc.com

Other

1.14k stars 207 forks source link

links to smc-in-smc are not properly detected #1838

Open haraldschilly opened 7 years ago

haraldschilly commented 7 years ago

Make misc_page/$.fn.process_smc_links smarter by detecting if a link is going to an smc-in-smc project (maybe look for port/<number>). Right now it thinks it is on in the same SMC environment and tries to open an editor tab. In reality, it should open a new browser tab.

haraldschilly commented 5 years ago

I think this works fine, since the default is opening a new tab … and only project specific links are detected explicitly

haraldschilly commented 5 years ago

oh, no, the heuristic is too simple by just checking for /projects/. the point is it matters if /projects/ is rather at the start, or later (after more slashes)