sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

investigate if we should update primus #2551

Open haraldschilly opened 6 years ago

haraldschilly commented 6 years ago

I've noticed that our primus is a bit old. Maybe we should update it to fix some connection issues?

This branch is my first step towards that: https://github.com/sagemathinc/cocalc/tree/primus7

With that, the dev-version works, but it seems like "ping" isn't doing anything? The API still has the same events, though.

williamstein commented 6 years ago

A good reason now is that upgrading should work around Safari too aggressively throttling websockets...

See https://github.com/socketio/socket.io/issues/2924#issuecomment-298694322 and https://github.com/primus/primus/pull/534