search

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.15k stars 209 forks source link

mapToProps: store_name of spec *must* be defined #3766

Open haraldschilly opened 5 years ago

haraldschilly commented 5 years ago

This happens for "zip" files

chrome: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36

smc_git_rev: 102fc19a0a586c0b4557af63ab9bb5124228f24e

Date: 2019-04-21 09:26:26.402092

store_name of spec *must* be defined

Error: store_name of spec *must* be defined
    at Function.mapToProps (https://cocalc.com/static/smc-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:5:8448)
    at n (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6925727)
    at Function.n.mapToProps (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6925845)
    at n (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6925709)
    at https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6927091
    at https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6927129
    at Object.run (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6923663)
    at s.c.initSelector (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6923844)
    at new s (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:6922612)
    at ai (https://cocalc.com/static/0-682e2964cdf20a77bb6f.cacheme.js?682e2964cdf20a77bb6f:6:4300475)
williamstein commented 5 years ago

I just tried unzipping a zip file (on my ipad with cocalc) and it seemed to work fine. How does one reproduce this? Is it a heisenbug? Or Safari only or something? @DrXyzzy ?

DrXyzzy commented 5 years ago

I haven't seen errors unzipping .zip archives from the Files list lately on macOS & ChromeOS. @haraldschilly, can you provide context?

haraldschilly commented 5 years ago

well, all the context I have is above. I tried to replicate it, in various ways, but no luck. Hmm …

williamstein commented 5 years ago

NOTE: I've changed the text of this error in app-framework.ts to be clearer:

-        throw Error("store_name of spec *must* be defined");
+        throw Error(
+          "WARNING: redux spec is invalid because it contains 'undefined' as a key. " + JSON.stringify(spec)
+        );
haraldschilly commented 5 years ago

well, after that change I'm not much wiser:

Error: WARNING: redux spec is invalid because it contains 'undefined' as a key. {"undefined":{}}
    at Function.mapToProps (https://cocalc.com/static/smc-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:5:8438)
    at n (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7409586)
    at Function.n.mapToProps (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7409704)
    at n (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7409568)
    at https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7410950
    at https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7410988
    at Object.run (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7407522)
    at s.c.initSelector (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7407703)
    at new s (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:7406471)
    at ai (https://cocalc.com/static/0-9172f4cb34eb6ab47f54.cacheme.js?9172f4cb34eb6ab47f54:6:4539085)
williamstein commented 5 years ago

well, after that change I'm not much wiser:

I didn't change anything else to prevent this -- I just changed the error message.

This is the sort of thing maybe Typescript could detect at compile time some day... Hmm... @johnjeng -- any ideas?