sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.16k stars 212 forks source link

make @mention completion consistent with Jupyter notebooks and command line python #3938

Open DrXyzzy opened 5 years ago

DrXyzzy commented 5 years ago

In chat, if you start an @-mention by typing e.g. @h, the list of choices includes all names that include the letter 'h'. It should be limited to choices that begin with 'h.

mention-h

DrXyzzy commented 5 years ago

Current implementation is also inconsistent with Facebook.

@-mention search in a github issue appears to put matches for the first character typed first, followed by names that contain a match to the first character typed anywhere

additional notes from @williamstein: Checked https://signavio.github.io/react-mentions/master/ and this [present behavior] is the default react-mentions behavior. The docs say you can pass a function in to do the filtering, so this will be easy to fix.