sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 217 forks source link

rewrite cocalc-jupyter find to be better #3976

Open williamstein opened 5 years ago

williamstein commented 5 years ago

REQUESTED BY Greg Ferenstein who says: "right now its hard to jump and skip. using the find function comes up with a window that i normally dont use find for. the way a browser uses find seems more natural. it instantly skips to the section. google colab also has a nice feature that uses a table of contents with collapsable sections. thanks for working on it! :)". His requirement is that it works well on an iPad Pro.

Regarding the current find implementation, I implemented that as a copy of classical Jupyter's find interface, because I wanted cocalc-jupyter to at least initially have the same user interface as classical Jupyter.

williamstein commented 1 year ago

We do have a table of contents now.

williamstein commented 1 year ago

Notably absent from the current implementation is moving the cursor to the results of find: "When I am in a notebook I would like to search for a word or words and then be taken to the location of them. If I use the find feature on the left toolbar it will show me the results but it does not take me to them. How can I be taken to the results of the find feature?"

williamstein commented 4 months ago

A related issue with JupyterLab that's currently very active: https://github.com/jupyterlab/jupyterlab/issues/15966

williamstein commented 2 months ago

Realistically, this isn't really a bug...