Explicitly disable use of grammarly across CoCalc (was: Enable use of grammarly chrome extension)

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud

https://CoCalc.com

Other

1.14k stars 208 forks source link

Explicitly disable use of grammarly across CoCalc (was: Enable use of grammarly chrome extension) #4207

Closed dpotter closed 1 year ago

dpotter commented 4 years ago

I regularly use the Grammarly Chrome browser extension to check my grammar and spelling. Would it be possible to adjust the CoCalc UI text boxes to allow it to operate?

text box requirements :

Below is a screenshot of the extension working on this text when I typed it.

haraldschilly commented 4 years ago

which parts of the CoCalc UI do you mean? e.g. Grammarly works in chat.

haraldschilly commented 4 years ago

I briefly looked into this. For CodeMirror inputs, the option inputStyle: "contenteditable" might cause it to be active, but it's not really working? I also have no idea about what implications this setting has.

williamstein commented 4 years ago

I think he wants this for Jupyter notebooks.
This issue seems to think it is impossible to use Codemirror + grammarly.
We could implement spell check ourselves for codemirror. We have "underline misspelled words" already (we don't use it for markdown cells in jupyter but could), and could add something to show corrections...

williamstein commented 1 year ago

Actually, what we should do is somehow change all of cocalc disable use of Grammarly. That extension mysteriously and randomly crashes things all over cocalc, but there is a way using CSS (I think) to disable it site-wise. There's a lot in these issues about how to do this: https://github.com/ianstormtaylor/slate/issues?q=is%3Aissue+grammarly+is%3Aclosed

williamstein commented 1 year ago

I tried all of the data-gramm style attributes, and none of them disable Grammarly anymore.
I tried using this CSS, and it does seem to work to make Grammarly not appear:
```
grammarly-extension {
display: none;
}
```
However, here is the thing. I wasn't able to reproduce any cases where Grammarly crashed cocalc or where making replacements didn't work, at least in our fork of slate-react. For example, even this recent issue https://github.com/ianstormtaylor/slate/pull/4809 doesn't seem to happen for me when I try it in cocalc.
So I'm going to close this issue until there is a reproducible case where Grammarly actually crashes cocalc. I've heard reports that there are, but I've never seen one.

williamstein commented 1 year ago

Relevant discussion: https://stackoverflow.com/questions/37444906/how-to-stop-extensions-add-ons-like-grammarly-on-contenteditable-editors