search

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

should we rewrite our little bit of CSS to not be in the sass language (just straight css?) #5139

Open williamstein opened 3 years ago

williamstein commented 3 years ago

Motivation:

  1. The node-sass project is deprecated "After much discussion among the Sass core team, we’ve come to the conclusion that it’s time to officially declare that LibSass and the packages built on top of it, including Node Sass, are deprecated. For several years now, it’s been clear that there’s simply not enough engineering bandwidth ..." https://sass-lang.com/blog/libsass-is-deprecated
  2. I personally don't know sass at all anyways. I know straight CSS much better. Any time I copy CSS from an example or write it myself, I have to convert it to sass to include it in cocalc, which is kind of silly.
  3. We barely ever touch our sass/css files anyways, since most style is in our code (react).
  4. I just hit a problem building node-sass on Windows 10, which is what motivated me to create this issue and look into the status of node-sass.
  5. We're at version 4.14.1 in cocalc, but there is a 5.0.0 release of node-sass, so we're even behind.

What do you think @haraldschilly ?

williamstein commented 3 years ago

Just to be clear: this is one of those low priority "luxury" issues, where it's amazing that we even have the time to consider it.

williamstein commented 3 years ago

This looks pretty nice for inline styles that are css friendly. https://emotion.sh/docs/introduction

haraldschilly commented 3 years ago

well, the big benefit of sass as we have it right now is that it is compact. unraveling all these nested definitions makes this larger and harder to maintain.

that deprecation note actually just tells everyone to switch to dart sass, which is the sass package. webpack recommends using dart sass.

if I have a clear head for this, maybe I should look into this and switch out sass and also that outdated uglifyjs lib.