sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

nbgrader: do not start student project if grading happens in a different project #5275

Open haraldschilly opened 3 years ago

haraldschilly commented 3 years ago
  1. For nbgrading, the "Grade assignments in a project of your choice" is set to a completely different project.
  2. When running nbgrader, one of the status indicators says it waits until the student project is running.

Problem is, this isn't necessary for private cocalc installs and also, as I can see right now, it never stops waiting.

I think in that case it should never wake up the project. The copy operation should do on its own, if necessary.

haraldschilly commented 3 years ago

ok, by reading the code, I see the grader function has at one point:

grade_project_id = nbgrader_grade_project

and later it does

const id = this.course_actions.set_activity({
          desc: `Ensuring ${store.get_student_name(
            student_id
          )}'s project is running`,
        });
        try {
          await start_project(grade_project_id, 60);

which is the wrong text. it's not the student project, but the 3rd-party project it tries to start for grading.