search

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.16k stars 211 forks source link

upgrade darkreader -- blocked on major issue with upstream #5591

Open williamstein opened 2 years ago

williamstein commented 2 years ago

This is caused by https://github.com/darkreader/darkreader/pull/6957. See https://github.com/sagemathinc/cocalc/issues/5588.

For now we can fix this by instally darkreader version 4.9.35 and absolute do NOT allow any later version.

I see no way to ever upgrade darkreader if we can't convince the darkreader project to make https://github.com/darkreader/darkreader/pull/6957 optional (on by default) so we can disable it, since that change makes darkreader completely incompatible with MathJax v2.

NOTE: I'm putting a check in src/packages/frontend/account/dark-mode.ts that will crash cocalc on startup if any version other than 4.9.35 of darkreader is installed. So you'll need to remove that as part of resolving this ticket.

williamstein commented 2 years ago

Another option would be to finally switch to MathJax v3 (see https://github.com/sagemathinc/cocalc/issues/4417), or just give up on MathJax entirely.

williamstein commented 2 years ago

I've created https://github.com/darkreader/darkreader/issues/7536, but I suspect they will just close it, since I haven't put in all the work to create a full reproducible test case. Also, I don't know if they even care about darkreader being compatible with MathJax v2...