sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.15k stars 209 forks source link

frontend OOM banner: enable for non-commercial #5969

Open haraldschilly opened 2 years ago

haraldschilly commented 2 years ago

The OOM banner right now just does if ( !is_commercial ) { return null; }.

But for private on-prem kubernetes setups, that OOM counter should be available as well. The goal of this ticket is to not suppress it. Of course, if the banner shows up, the message must be different – e.g. asking to contact an admin for a larger memory quota.

williamstein commented 2 years ago

side note: The OOM'ing and banner worked extremely well during the talk today to provide context, and also didn't actually break anything.