search

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

account settings/tours: properly fix re-enabling a tour #6929

Open haraldschilly opened 1 year ago

haraldschilly commented 1 year ago

When unchecking a tour, in account/actions.ts there is this line in setTourNotDone:

table.set({ tours: tours.map((x) => x != tour) });

and I don't know how this is supposed to work. The moment something is unchecked, the array is full of true | false entries, essentially disabling all tours. I tried to fix it by replacing the map by filter, but that's causing even more strange problems.

haraldschilly commented 1 year ago

PR https://github.com/sagemathinc/cocalc/pull/6905 includes an ugly fix for that