sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

Notifications about recently edited files do not close #6961

Open novoselt opened 1 year ago

novoselt commented 1 year ago

Clicking on the circle shows up the panel with recently edited files, as expected, but then this panel remains open when clicking on projects tabs and especially the mentions envelope, which feels weird. I would expect the notification panel to close when I am trying to switch to a different view.

Perhaps "the right way" to fix it is to implement these notifications in the same way and mentions? They seem to be very closely related, so it is strange that different types of panels are used for them.

williamstein commented 1 year ago

Perhaps "the right way" to fix it is to implement these notifications in the same way and mentions?

@haraldschilly actually very recently implemented the mentions/news page. The current notifications panel with the number is really, really old, and was modeled on how facebook once worked. I agree that it would be better to just move the functionality to be part of the new mentiones/news page that Harald created. It's a better approach that also feels more consistent with the rest of cocalc.

williamstein commented 9 months ago

We should just somehow merge this notification thing with the new envelope news/mentions panel. That's the right fix.