search

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

frontend: generic/test: do we use this? #7254

Closed haraldschilly closed 8 months ago

haraldschilly commented 8 months ago

When investigating where we use the chai package, I saw a bunch of code files in .../frame-editors/generic/test/

Do we run those tests? If so, how? The code is 6 years old, and that made me suspicious.

I propose to either add a note to the README in that directory explaining how to run this, or we remove this (and uninstall chai)

williamstein commented 8 months ago

Just remove it. The only automated unit tests that are run on the frontend package right now is one trivial proof-of-concept test of components/A.test.ts. All other frontend testing code can be deleted. 

~/cocalc/src/packages/frontend$ pnpm test

> @cocalc/frontend@1.102.7 test /projects/59756877-e9db-4a99-8489-ad5f96695c14/cocalc/src/packages/frontend
> npx jest dist/

 PASS  dist/components/A.test.js
  ✓ some basic properties of A are correct so will open a new tab at right url (8 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        2.18 s
Ran all test suites matching /dist\//i.
~/cocalc/src/packages/frontend$
haraldschilly commented 8 months ago

Yes, I thought so as well

On Wed, Feb 7, 2024 at 6:45 PM William Stein @.***> wrote:

Just remove it. The only automated unit tests that are run on the frontend package right now is one trivial proof-of-concept test of components/A.test.ts. All other frontend testing code can be deleted.

~/cocalc/src/packages/frontend$ pnpm test

@@.*** test /projects/59756877-e9db-4a99-8489-ad5f96695c14/cocalc/src/packages/frontend npx jest dist/

PASS dist/components/A.test.js ✓ some basic properties of A are correct so will open a new tab at right url (8 ms)

Test Suites: 1 passed, 1 total Tests: 1 passed, 1 total Snapshots: 0 total Time: 2.18 s Ran all test suites matching /dist\//i. ~/cocalc/src/packages/frontend$

— Reply to this email directly, view it on GitHub https://github.com/sagemathinc/cocalc/issues/7254#issuecomment-1932565696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSULIYMOEP55LI5QFXU7LYSO4TVAVCNFSM6AAAAABC6ARQ42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGU3DKNRZGY . You are receiving this because you authored the thread.Message ID: @.***>