search

sagemathinc / cocalc

CoCalc: Collaborative Calculation in the Cloud
https://CoCalc.com
Other
1.17k stars 216 forks source link

Not Obvious How to (was: Cannot) Unpublish or Change Visibility After Renaming Document Published on CoCalc ShareServer #7863

Open Blaec-CoCalc opened 1 month ago

Blaec-CoCalc commented 1 month ago

Describe the bug Renaming a document published to the CoCalc ShareServer makes it seemingly impossible to unpublish. The file prompt to unpublish or use "public unlisted" won't appear since the file has been renamed.

To Reproduce Steps to reproduce the behavior:

  1. Publish a document to the CoCalc ShareServer.
  2. Rename the published document.
  3. Attempt to unpublish the document or change its visibility.

Expected behavior The prompt to unpublish or change the visibility of the renamed document should appear, allowing the user to manage the document's published status.

Screenshots If applicable, add screenshots to help explain your problem. If the screenshots include text, make sure to also include that text separately so that we can copy and paste it and not have to type it in again!

Example: https://cocalc.com/share/public_paths/94d4e4fc575dc94cb098004735a5611f0400c7a8

Listed Here: https://cocalc.com/settings/public-files

Account: BlaecAlexander@gmail.com

Additional context This bug makes it challenging to manage documents that have been renamed after being published, leading to potential inconsistencies and user confusion.

williamstein commented 1 month ago

"Cannot ..." is not correct. You just have to make a file there again, then you can configure anything about how it is published. You can also unpublish or change visibility by opening the document on the share server and clicking edit.

williamstein commented 1 month ago

The publishing status is tied to the path/filename, not the actual file, and there are many ways to rename a file (e.g., in the terminal, via git checkout, the frontend UI, moving a folder that contains a file, etc.). Given this, right now if you rename a shared file (which is in general ill defined to even detect), then it shouldn't rename what is shared. So an additional problem is that there's literally nowhere in the directory listing where you can see that file that you removed in order to see the pane for editing the share status.

All shared files are listed here though: https://cocalc.com/settings/public-files
That listing though doesn't let you change the publishing status of particular entries (only "unpublish all"). But it would be easy to add a way to unpublish specific entries or make them private.

We could also add a similar per-project page. I don't know where it would go.