Add OS dependency flag to package.json to allow inclusion on other platforms

saghul / node-abstractsocket

Abstract namespace socket support for Node

MIT License

24 stars 13 forks source link

Add OS dependency flag to package.json to allow inclusion on other platforms #3

Closed JetForMe closed 9 years ago

JetForMe commented 9 years ago

I was using a node module that optionally includes node-abstract socket. On OS X, node-abstractsocket gets a compile error. Specifying the OS requirement in node-abstractsocket's package.json file allows it to skip trying to build on OS X.

saghul commented 9 years ago

Thanks! Do you mind squashing all commits into one?

JetForMe commented 9 years ago

Heh, I don't mind, but this is my first pull request, and I don't really know how to do that.

JetForMe commented 9 years ago

Here you go, commits squashed.

saghul commented 9 years ago

Fantastic! Thanks Rick!

JetForMe commented 9 years ago

No prob, thanks!

Sent from my iPhone

On Mar 25, 2015, at 02:24, Saúl Ibarra Corretgé notifications@github.com wrote:

Fantastic! Thanks Rick!

— Reply to this email directly or view it on GitHub.