search

saghul / pycares

Python interface for c-ares
https://pypi.org/project/pycares/
MIT License
163 stars 74 forks source link

Add Type Annotations #112

Open cooperlees opened 4 years ago

cooperlees commented 4 years ago

It would be nice to have the pycares code base was type annotated or stubbed. This will allow users to ensure they are always passing correct types and will probably find a subtle bug or two.

One example is aiodns has to disable checking pycares due to not type annotation when running mypy.

saghul commented 4 years ago

I don't think I'll have the time or inclination to do this myself, but I will welcome a PR :-)