search

saghul / pycares

Python interface for c-ares
https://pypi.org/project/pycares/
MIT License
163 stars 74 forks source link

ffi: new style callbacks #119

Closed Snawoot closed 4 years ago

Snawoot commented 4 years ago

Closes #118

Refactored ffi callbacks to new extern "Python" style in order to avoid use of libffi callbacks and W+X mempages usage.

Snawoot commented 4 years ago

2 checks failed due to networking errors. BTW, when I checked logs of failed jobs there were "unable download log" errors popping up from GH Actions UI, so I think we're good.

saghul commented 4 years ago

I reran the tests and it' all clear! Thanks for your contribution!

Snawoot commented 4 years ago

Hello!

Could you please make pycares release with this fix soon? Mentioned issue breaks at least following packages (because distro provided version of pycares is newer than 3.0.0 and W+X mempages disabled by systemd unit file):

https://packages.debian.org/bullseye/postfix-mta-sts-resolver https://packages.debian.org/sid/postfix-mta-sts-resolver https://packages.ubuntu.com/focal/postfix-mta-sts-resolver

saghul commented 4 years ago

Sure thing, I;'ll try to cut a release tonight!

saghul commented 4 years ago

pycares 3.1.1 has just been released. Please let me know if it's all good now. Cheers!

Snawoot commented 4 years ago

@saghul works just fine, thank you!!!