Closed HassanAbouelela closed 3 years ago
Just a slight hiccup in the python installation, but I'll look into fixing that.
Edit: Not really sure. Maybe it has to do with the config? 3.9(.1) should be supported on AV, and it does work in my copy.
App veyor is working again, I think that's everything.
Awesome! I triggered GH actions as well. 🤞
Reworded the commits and landed in master, thank you so much!
Description
This PR bumps the pypi package to 3.2.0 and python version 3.9. It introduces no changed functionality for end-users.
Changes
CI Runs
Here are my successful CI runs: AppVeyor Travis Mac CI
Suggestions
I do have some minor suggestions to address the points about tests. Currently, the tests use sites from all over the internet, which (I assume) you have no control over, leading to tests just breaking over time. I suggest that you either only use domains you control, or more feasibly, run a local DNS server from the test suite so you can have full control over the conditions. I can't say how easy that'll be, but it's definitely easier than scouring the internet and hoping sites don't change their DNS too frequently.