search

saghul / pycares

Python interface for c-ares
https://pypi.org/project/pycares/
MIT License
162 stars 74 forks source link

Update parse_result to allow CNAME answers to A queries #162

Closed maelp closed 3 years ago

maelp commented 3 years ago

I updated the code using something similar to what is done for CNAME responses, but looking at the code it seems that there might be some memory leaks in many of those handlers: each time we do a ffi.new and there is a parsing error, it seems we do not free the allocated memory

maelp commented 3 years ago

Ah, I actually see from FFI that the ffi.new keeps ownership of allocated data, so there shouldn't be a memory leak

saghul commented 3 years ago

I think this is going to need a major bump. No problem with that though.

maelp commented 3 years ago

I updated the version to 5.0.0

maelp commented 3 years ago

I merged this code in the other PR