search

saghul / pycares

Python interface for c-ares
https://pypi.org/project/pycares/
MIT License
162 stars 74 forks source link

Test data updates to fix test failures #192

Closed kitterma closed 7 months ago

kitterma commented 7 months ago

Currently we have multiple test failures with pycares 4.4.0 with c-ares 1.24. Two of the three are unrelated to the new c-ares version:

For test_query_txt_chunked, the jobscoutdaily.com SPF record changed, so the expected result is wrong. I think it still has the relevant attributes for the test case.

For test_query_ptr, there's no longer a PTR record at 8.8.8.8, so the test failed with pycares (correctly) reported an error. It looks like any address with a PTR record will meet the requirements for the test, so I replaced it with the address of one of Google's mail servers.

I'll submit a separate PR for the change related to the newer c-ares.

Scott K

saghul commented 7 months ago

Thank you!

kitterma commented 4 months ago

The jobscoutdaily.com SPF record changed again, so this now fails again:

jobscoutdaily.com. 21600 IN TXT "v=spf1 A MX " "include:emailcampaigns.net include:spf.dynect.net include:ccsend.com include:_spf.elasticemail.com ip4:67.200.116.0/24 ip4:74.199.198.0/24 " " ~all"

When I have time, I'll try to submit an updated PR, but it may be awhile.

kitterma commented 4 months ago

Or not. Now I'm not sure what's going on.

kitterma commented 4 months ago

So, it looks like they changed it a few months ago and then recently changed it back, so I think we're fine.