Do not define HAVE_GETSERVBYPORT_R for platforms Android, Cygwin, Darwin

saghul / pycares

Python interface for c-ares

https://pypi.org/project/pycares/

MIT License

162 stars 74 forks source link

Closed truboxl closed 6 months ago

truboxl commented 6 months ago

This PR fix a long standing issue which Android build keep failing due to undefined getservbyport_r in bionic libc.

I think you can close all Android issues for good like #191 since it obviously a user mistake.

saghul commented 6 months ago

Can you just delete the lines instead please?

truboxl commented 6 months ago

I don't see other ares_config.h delete the lines

saghul commented 6 months ago

So? Delete them please.

truboxl commented 6 months ago

You mean delete the other ares_config.h lines?

saghul commented 6 months ago

Instead of putting "undef" and commenting the line out, just delete the line.

truboxl commented 6 months ago

I follow what other ares_config.h do (undef and comment).

So if I do another (delete the line and comments) shouldnt it be applied to others?

saghul commented 6 months ago

Oh, sorry! I hadn't realized that's how it was done for other options! This is good then,