saghul / pycares

Python interface for c-ares
https://pypi.org/project/pycares/
MIT License
165 stars 73 forks source link

Use None instead of -1 to fallback to default. #61

Closed Kentzo closed 5 years ago

Kentzo commented 6 years ago

Refs #59.

Kentzo commented 6 years ago

Perhaps None should mapped to -1 / -1.0 before reaching C-part?

saghul commented 6 years ago

Perhaps None should mapped to -1 / -1.0 before reaching C-part?

There is no Python part for the CPython core, it's all in C. The Python code you modified is for PyPy.

Kentzo commented 6 years ago

Oh ok, missed that.

saghul commented 5 years ago

Fixed in https://github.com/saghul/pycares/pull/83